From owner-freebsd-wireless@freebsd.org  Mon Dec 11 16:18:16 2017
Return-Path: <owner-freebsd-wireless@freebsd.org>
Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 07BDEE96A03
 for <freebsd-wireless@mailman.ysv.freebsd.org>;
 Mon, 11 Dec 2017 16:18:16 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E3DBD6CAE5
 for <freebsd-wireless@FreeBSD.org>; Mon, 11 Dec 2017 16:18:15 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vBBGIFKJ002887
 for <freebsd-wireless@FreeBSD.org>; Mon, 11 Dec 2017 16:18:15 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-wireless@FreeBSD.org
Subject: [Bug 224141] possible Off-by-one bug in the Base64 decoding in the
 wpa supplicant
Date: Mon, 11 Dec 2017 16:18:16 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: wireless
X-Bugzilla-Version: CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: ikostov@gmail.com
X-Bugzilla-Status: Closed
X-Bugzilla-Resolution: Works As Intended
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-wireless@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-224141-21060-iteem1Y8PJ@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-224141-21060@https.bugs.freebsd.org/bugzilla/>
References: <bug-224141-21060@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-wireless@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "Discussions of 802.11 stack,
 tools device driver development." <freebsd-wireless.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-wireless>, 
 <mailto:freebsd-wireless-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-wireless/>
List-Post: <mailto:freebsd-wireless@freebsd.org>
List-Help: <mailto:freebsd-wireless-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
 <mailto:freebsd-wireless-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Dec 2017 16:18:16 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D224141

--- Comment #2 from Ivan Kostov <ikostov@gmail.com> ---
Hi Tim,

I have modified the source code a little bit before using it in my project.=
 As
it turns out I have changed the line=20


static const unsigned char base64_table[65] =3D ....

to=20

static const unsigned char base64_encode_table[] =3D

which allocates indeed one byte less :). Sorry for the time lost :D=20
However I don't find it sexy, to allocate 65 bytes and initialize only 64 of
them and rely on the fact that static variables usually land in the .bss.
The code will work by initializing 64 elements and removing the " -1 " from=
 the
for loop.

Best regards,
Ivan

--=20
You are receiving this mail because:
You are the assignee for the bug.=