From owner-svn-ports-head@FreeBSD.ORG Sun Sep 7 23:43:05 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 76BFE148; Sun, 7 Sep 2014 23:43:05 +0000 (UTC) Received: from mail-wi0-x22e.google.com (mail-wi0-x22e.google.com [IPv6:2a00:1450:400c:c05::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49D291C50; Sun, 7 Sep 2014 23:43:04 +0000 (UTC) Received: by mail-wi0-f174.google.com with SMTP id d1so1776592wiv.1 for ; Sun, 07 Sep 2014 16:43:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=0LP6nhwtQk/vDEcNdNNkgoPH8+AXpscyPpYvCiAA5Z0=; b=e1CAHl7ThyNP1i2rxgomEwEzqx8+vP3T1RyohkYiNmHNu5rv9dGu6i3cVU5R0+0g2/ twJ85mvlrhX01CSqev3iQc9SKpzGuW66KPuJlHhBqXg9WIVPUEAegZLgXA7HZKk7+yYx XoZGh+NlgJRRqd0HMPe79VquwvEJ3GGhFVqruwJVTTMY9pZDF0UshMQJzKMQnd79DAhi OKgDHkNh1pdDSt2so1ufb+sjahu5jqPY6+plEtLihM84TuPv2xFv4AWAfddWc/GZQ66D 5I2T1ogNaD78Itf/sMVuwLAg6dwJpzlkpQD8MvjuMsPo7iwuCG4i7wvOCPvVLMNnpO3N tjJQ== X-Received: by 10.194.63.37 with SMTP id d5mr31010857wjs.92.1410133382604; Sun, 07 Sep 2014 16:43:02 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id u7sm9784920wif.7.2014.09.07.16.43.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 Sep 2014 16:43:01 -0700 (PDT) Sender: Baptiste Daroussin Date: Mon, 8 Sep 2014 01:42:59 +0200 From: Baptiste Daroussin To: marino@freebsd.org Subject: Re: svn commit: r367404 - in head/security: . webshag webshag/files Message-ID: <20140907234259.GC6096@ivaldir.etoilebsd.net> References: <201409060746.s867kwJ4038485@svn.freebsd.org> <540AD4A8.4050705@FreeBSD.org> <540AD92E.5030602@marino.st> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KDt/GgjP6HVcx58l" Content-Disposition: inline In-Reply-To: <540AD92E.5030602@marino.st> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-ports-head@freebsd.org, koobs@FreeBSD.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, clutton@zoho.com, Carlo Strub X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Sep 2014 23:43:05 -0000 --KDt/GgjP6HVcx58l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 06, 2014 at 11:51:42AM +0200, John Marino wrote: > On 9/6/2014 11:32, Kubilay Kocak wrote: > > On 6/09/2014 5:46 PM, Carlo Strub wrote: > >> +LICENSE=3D GPLv3 > >=20 > > LICENSE_FILE >=20 > I know mat's position, but this decree was definitely controversial. > Many people don't agree that LICENSE_FILE is needed when the provided > license is identical to the one offered in ports Templates directory. > And since the licensing framework is still an unsupported and mostly > undocumented red-headed stepchild of ports, I don't think I agree with > saying this was an error. >=20 > >> +bin/webshag_cli > >> +%%WXGTK%%bin/webshag_gui > >> +%%ETCDIR%%.conf > >=20 > > Does this need a filename? >=20 >=20 > This is probably a wonderful side effect of make makeplist which > aggressively creates SUB replacements, often incorrectly. > This was probably /etc/${PORTNAME}.conf and it got transformed and > submitter didn't check closely enough. >=20 > I agree, DO NOT TRUST MAKEPLIST FURTHER THAN YOU CAN THROW IT! >=20 This is why the first line of make makeplist if wrong so one has to review! regards, Bapt --KDt/GgjP6HVcx58l Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlQM7YMACgkQ8kTtMUmk6ExK0ACfY3EJK+oIZuCC75Ch6kN4OxVq V48AoLFJ0DAZR/HkxSjDGylLQzNEei3w =smGv -----END PGP SIGNATURE----- --KDt/GgjP6HVcx58l--