From owner-freebsd-bugs@FreeBSD.ORG Tue Jun 10 10:40:15 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 04A2537B405 for ; Tue, 10 Jun 2003 10:40:15 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 194B743FCB for ; Tue, 10 Jun 2003 10:40:11 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h5AHeAUp016091 for ; Tue, 10 Jun 2003 10:40:10 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h5AHeAEd016090; Tue, 10 Jun 2003 10:40:10 -0700 (PDT) Resent-Date: Tue, 10 Jun 2003 10:40:10 -0700 (PDT) Resent-Message-Id: <200306101740.h5AHeAEd016090@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Bruce M Simpson Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4F51137B401 for ; Tue, 10 Jun 2003 10:33:55 -0700 (PDT) Received: from bigboy.spc.org (dolly.good1.com [195.206.69.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 484EC43FDF for ; Tue, 10 Jun 2003 10:33:52 -0700 (PDT) (envelope-from bms@spc.org) Received: from saboteur.dek.spc.org (unknown [81.3.72.84]) by bigboy.spc.org (Postfix) with ESMTP id C974D32B6 for ; Tue, 10 Jun 2003 18:37:54 +0100 (BST) Received: by saboteur.dek.spc.org (Postfix, from userid 1001) id 592B16C1; Mon, 9 Jun 2003 21:47:22 +0100 (BST) Message-Id: <20030609204722.592B16C1@saboteur.dek.spc.org> Date: Mon, 9 Jun 2003 21:47:22 +0100 (BST) From: Bruce M Simpson To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/53153: RESTARTABLE_PANICS debugging option is broken X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Bruce M Simpson List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jun 2003 17:40:15 -0000 >Number: 53153 >Category: kern >Synopsis: RESTARTABLE_PANICS debugging option is broken >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jun 10 10:40:10 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Bruce M Simpson >Release: FreeBSD 5.1-RELEASE i386 >Organization: >Environment: System: FreeBSD saboteur.dek.spc.org 5.1-RELEASE FreeBSD 5.1-RELEASE #0: Mon Jun 9 16:25:10 BST 2003 root@saboteur.dek.spc.org:/usr/src/sys/i386/compile/SABOTEUR i386 >Description: Including the RESTARTABLE_PANICS option in a kernel compile results in multiple errors of the following kind: xxxx might be used uninitialized in this function where xxxx is one of the first variables in the function. Affected functions have the following properties: 1) they call panic() 2) they have a non-void return value Here is a list of the affected files: src/sys/dev/ppbus/ppb_msq.c src/sys/fs/devfs/devfs_devs.c src/sys/fs/msdosfs/msdosfs_vnops.c src/sys/kern/kern_intr.c src/sys/kern/subr_bus.c src/sys/kern/uipc_usrreq.c src/sys/kern/vfs_default.c src/sys/netinet6/ip6_output.c src/sys/netinet6/ipsec.c src/sys/netinet6/nd6.c src/sys/ufs/ffs/ffs_alloc.c src/sys/ufs/ffs/ffs_softdep.c src/sys/vm/uma_core.c src/sys/i386/i386/elf_machdep.c src/sys/i386/i386/vm86.c We have to agree on how to resolve this. Either RESTARTABLE_PANICS should be removed outright, or a misleading prototype would have to be declared (continue to advertise it with __dead2 in , when it can in fact return). A kludge would have to be implemented in kern_shutdown.c. Otherwise all callers of panic() have to be changed to handle the 'panic() can return' case. >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: >Unformatted: