Date: Sun, 28 Jun 2015 23:27:59 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: olli hauer <ohauer@gmx.de> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r390865 - in head/Mk: . Scripts Message-ID: <20150628212759.GJ68142@ivaldir.etoilebsd.net> In-Reply-To: <55906609.2080905@gmx.de> References: <201506281850.t5SIocPn077890@svn.freebsd.org> <55906609.2080905@gmx.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--QxN5xOWGsmh5a4wb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 28, 2015 at 11:24:25PM +0200, olli hauer wrote: > On 2015-06-28 20:50, Baptiste Daroussin wrote: > > Author: bapt > > Date: Sun Jun 28 18:50:37 2015 > > New Revision: 390865 > > URL: https://svnweb.freebsd.org/changeset/ports/390865 > >=20 > > Added: > > head/Mk/Scripts/do-depends.sh (contents, props changed) > > Modified: > > head/Mk/bsd.port.mk > >=20 > > Added: head/Mk/Scripts/do-depends.sh > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/Mk/Scripts/do-depends.sh Sun Jun 28 18:50:37 2015 (r390865) >=20 > ... >=20 > > +find_file_path() > > +{ > > + if which -s $1 ; then > > + echo "=3D=3D=3D> ${dp_PKGNAME} depends on executable: $1 - found" > > + return 0 > > + fi >=20 > Shouldn't this be 's|which|${WHICH}|' or 's|which|/usr/bin/which|' as in = the old version? >=20 > E.g which in csh don't have parameter [a|s] well actually the script is always and only used via /bin/sh so we can use = the sh(1) builtin version of which :) Best regards, Bapt --QxN5xOWGsmh5a4wb Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlWQZt8ACgkQ8kTtMUmk6Ex/6gCbBaRvJVKj4thhhOD15EKb7s0w jngAoJFg7fjM+f5g/9b1+2MgSBTDGeVs =lbdl -----END PGP SIGNATURE----- --QxN5xOWGsmh5a4wb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150628212759.GJ68142>