From owner-freebsd-git@freebsd.org Thu Apr 22 20:07:46 2021 Return-Path: Delivered-To: freebsd-git@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 750A55FD618 for ; Thu, 22 Apr 2021 20:07:46 +0000 (UTC) (envelope-from crees@bayofrum.net) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4FR7kp1xH6z4l92 for ; Thu, 22 Apr 2021 20:07:46 +0000 (UTC) (envelope-from crees@bayofrum.net) Received: by mailman.nyi.freebsd.org (Postfix) id 405005FD616; Thu, 22 Apr 2021 20:07:46 +0000 (UTC) Delivered-To: git@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 400D95FD16E for ; Thu, 22 Apr 2021 20:07:46 +0000 (UTC) (envelope-from crees@bayofrum.net) Received: from mail264c50.megamailservers.eu (mail1422c50.megamailservers.eu [91.136.14.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FR7kn5f8sz4l4M; Thu, 22 Apr 2021 20:07:44 +0000 (UTC) (envelope-from crees@bayofrum.net) X-Authenticated-User: crees@uwclub.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1619122062; bh=askazOzzQqpGPe5reGWo4aoXIdVSWdvmKLe0eoQ3Zok=; h=Date:In-Reply-To:References:Subject:To:CC:From:From; b=hyjWMvgyEF9oupX7FAQ1U8GmatS9Ia50WEmPHMLL1/1s6HCkqxHv0Z+SzkTj3Lrbr uw25ULVhDqm7HyXiRN5eTtZXU412NEysSRmvNk8hUc8MeW4aqk+d7RW+mjE8Bgsw1x tl70lr46O3QFTdH8SmVAewLQIFyVDdSGHiliI6pI= Feedback-ID: crees@bayofrum. Received: from pegasus.bayofrum.net (host-92-6-219-129.as13285.net [92.6.219.129]) (authenticated bits=0) by mail264c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 13MK7eNV018939; Thu, 22 Apr 2021 20:07:41 +0000 X-Spam-Status: No X-bayofrum-MailScanner-From: crees@bayofrum.net X-bayofrum-MailScanner: Found to be clean X-bayofrum-MailScanner-ID: 35121518F.A22C0 X-bayofrum-MailScanner-Information: Please contact the ISP for more information Received: from Chriss-Galaxy-S9.bayofrum.net (Chriss-Galaxy-S9.bayofrum.net [192.168.1.148]) by pegasus.bayofrum.net (Postfix) with ESMTPSA id 35121518F; Thu, 22 Apr 2021 21:07:38 +0100 (BST) Date: Thu, 22 Apr 2021 21:07:38 +0100 User-Agent: K-9 Mail for Android In-Reply-To: References: <2257024.hWAQu6Pgo9@beastie.bionicmutton.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: One surprise in commit messages with git To: Enji Cooper , Adriaan de Groot CC: git@freebsd.org, developers@freebsd.org From: Chris Rees Message-ID: X-CTCH-RefID: str=0001.0A742F22.6081D78E.001C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=C+OXNjH+ c=1 sm=1 tr=0 a=QLs7qdLzT5i+06VJzUEftA==:117 a=QLs7qdLzT5i+06VJzUEftA==:17 a=IkcTkHD0fZMA:10 a=3YhXtTcJ-WEA:10 a=pGLkceISAAAA:8 a=6I5d2MoRAAAA:8 a=2bgUU40Z42YKlbvdtBYA:9 a=QEXdDO2ut3YA:10 a=IjZwj45LgO3ly-622nXo:22 X-Origin-Country: GB X-Rspamd-Queue-Id: 4FR7kn5f8sz4l4M X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-Mailman-Approved-At: Sat, 24 Apr 2021 08:08:27 +0000 X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2021 20:07:46 -0000 On 22 April 2021 20:29:42 BST, Enji Cooper wrote= : > >> On Apr 22, 2021, at 8:00 AM, Adriaan de Groot >wrote: >>=20 >> There are still some surprises in the pipeline that processes >commits=2E I >> triggered one today with f365336113=2E In my commit message, I was >fixing >> something in an earlier commit, so I wrote "(bla-di-bla, fixes) >ports >> 620d7678c8=2E" >>=20 >> The commit itself refers to a PR (with the usual PR: line), 255260=2E >So >> Bugzilla automation takes over, and pastes the commit into a comment >there=2E It >> looks to me like Bugzilla takes "ports [0-9]+" in the commit message >as an SVN >> reference -- the message as-pasted as a comment in Bugzilla then >surprisingly >> - links to svnweb (which still exists) >> - links to r620, which is 26 years old >>=20 >> Overall harmless enough, but surprising for things that >look-like-a-revision- >> number but are a really a prefix to a longer hash=2E > >Hi ade, > This probably deserves a Bugzilla bug so folks on the git@ end can >resolve the commit message parsing issue=2E >Cheers, Unfortunately, it's not really that simple- the revision parsing is done d= ynamically, so if you remove that regex from Bugzilla, historical bugs with= SVN references will no longer be linked=2E Whether that's a big deal or n= ot=2E=2E=2E I would suggest instead that the regex instead be "/ports \d\d\d\d\d+/"- t= his would almost eliminate false positives with git, and preserve older lin= ks, assuming that the first SVN commit is indeed after 99999=2E=2E=2E which= off the top of my head it definitely is! Chris