Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 01 May 2013 17:41:52 +1000
From:      Lawrence Stewart <lstewart@freebsd.org>
To:        freebsd-hackers@freebsd.org
Subject:   Re: Adding a FOREACH_CONTINUE() variant to queue(3)
Message-ID:  <5180C740.1060104@freebsd.org>
In-Reply-To: <5180AF55.5070000@freebsd.org>
References:  <518092BF.9070105@freebsd.org> <74840.1367386143@critter.freebsd.dk> <5180AF55.5070000@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 05/01/13 15:59, Lawrence Stewart wrote:
> On 05/01/13 15:29, Poul-Henning Kamp wrote:
>> In message <518092BF.9070105@freebsd.org>, Lawrence Stewart writes:
>>> [reposting from freebsd-arch@ - was probably the wrong list]
>>
>>> #define TAILQ_FOREACH_CONTINUE(var, head, field)		\
>>
>> Obligatory bikeshedding:
>>
>> I find the suffix "_CONTINUE" non-obvious, as there may not have
>> been any previos FOREACH involved.
>>
>> TAILQ_FOREACH_FROM(...) ?
> 
> Agreed. Thanks for the input.

Here's an untested patch for consideration:

http://people.freebsd.org/~lstewart/patches/misc/queue_foreach_from_10.x.r250136.patch

I didn't do _SAFE variants as I don't have an immediate use for them.

Cheers,
Lawrence



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5180C740.1060104>