Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 5 Aug 2019 20:26:01 +0000 (UTC)
From:      Mariusz Zaborski <oshogbo@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r350616 - head/sys/kern
Message-ID:  <201908052026.x75KQ1UU094795@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: oshogbo
Date: Mon Aug  5 20:26:01 2019
New Revision: 350616
URL: https://svnweb.freebsd.org/changeset/base/350616

Log:
  process: style
  
  We don't need to check if the parent is already set.
  This is done already in the proc_reparent.
  
  No functional behaviour changes intended.
  
  MFC after:	1 month

Modified:
  head/sys/kern/sys_process.c

Modified: head/sys/kern/sys_process.c
==============================================================================
--- head/sys/kern/sys_process.c	Mon Aug  5 20:21:35 2019	(r350615)
+++ head/sys/kern/sys_process.c	Mon Aug  5 20:26:01 2019	(r350616)
@@ -958,9 +958,7 @@ kern_ptrace(struct thread *td, int req, pid_t pid, voi
 		 * on a "detach".
 		 */
 		proc_set_traced(p, true);
-		if (p->p_pptr != td->td_proc) {
-			proc_reparent(p, td->td_proc, false);
-		}
+		proc_reparent(p, td->td_proc, false);
 		CTR2(KTR_PTRACE, "PT_ATTACH: pid %d, oppid %d", p->p_pid,
 		    p->p_oppid);
 
@@ -1109,7 +1107,7 @@ kern_ptrace(struct thread *td, int req, pid_t pid, voi
 		    p->p_pid, psr->sr_error, psr->sr_retval[0],
 		    psr->sr_retval[1]);
 		break;
-		
+
 	case PT_STEP:
 	case PT_CONTINUE:
 	case PT_TO_SCE:
@@ -1219,8 +1217,8 @@ kern_ptrace(struct thread *td, int req, pid_t pid, voi
 
 	sendsig:
 		MPASS(proctree_locked == 0);
-		
-		/* 
+
+		/*
 		 * Clear the pending event for the thread that just
 		 * reported its event (p_xthread).  This may not be
 		 * the thread passed to PT_CONTINUE, PT_STEP, etc. if



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201908052026.x75KQ1UU094795>