From owner-freebsd-pf@FreeBSD.ORG  Mon Jun 13 14:22:39 2005
Return-Path: <owner-freebsd-pf@FreeBSD.ORG>
X-Original-To: freebsd-pf@freebsd.org
Delivered-To: freebsd-pf@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 40DBA16A41C;
	Mon, 13 Jun 2005 14:22:39 +0000 (GMT)
	(envelope-from mlsmith@mitre.org)
Received: from smtp-bedford-dr.mitre.org (smtp-bedford-dr-x.mitre.org
	[192.160.51.65])
	by mx1.FreeBSD.org (Postfix) with ESMTP id ACB1A43D49;
	Mon, 13 Jun 2005 14:22:38 +0000 (GMT)
	(envelope-from mlsmith@mitre.org)
Received: from smtp-bedford-dr.mitre.org (localhost.localdomain [127.0.0.1])
	by smtp-bedford-dr.mitre.org (8.11.6/8.11.6) with SMTP id j5DEMSx30795; 
	Mon, 13 Jun 2005 10:22:28 -0400
Received: from smtp-bedford-dr.mitre.org (localhost.localdomain [127.0.0.1])
	by smtp-bedford-dr.mitre.org (Postfix) with ESMTP
	id 9843D4F8DB; Mon, 13 Jun 2005 10:22:28 -0400 (EDT)
Received: from MAILHUB1 (mailhub1.mitre.org [129.83.20.31])
	by smtp-bedford-dr.mitre.org (8.11.6/8.11.6) with ESMTP id j5DEMSV30726;
	Mon, 13 Jun 2005 10:22:28 -0400
Received: from mm112487-2k.mitre.org (128.29.50.27) by mailhub1.mitre.org with
	SMTP id 18416013; Mon, 13 Jun 2005 10:22:24 -0400
Message-ID: <05e001c57023$5189d180$1b321d80@MITRE.ORG>
From: "PSI, Mike Smith" <mlsmith@mitre.org>
To: <gtg062h@mail.gatech.edu>, <freebsd-net@freebsd.org>,
	<freebsd-pf@freebsd.org>
References: <7c8f2792050610090049064e11@mail.gmail.com>
	<7c8f279205061116021f55e8da@mail.gmail.com>
	<7c8f279205061307103b1782f4@mail.gmail.com>
Date: Mon, 13 Jun 2005 10:22:24 -0400
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1437
X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2800.1441
Cc: 
Subject: Re: Carp Suppression
X-BeenThere: freebsd-pf@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Technical discussion and general questions about packet filter
	\(pf\)" <freebsd-pf.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
	<mailto:freebsd-pf-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-pf>
List-Post: <mailto:freebsd-pf@freebsd.org>
List-Help: <mailto:freebsd-pf-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
	<mailto:freebsd-pf-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jun 2005 14:22:39 -0000

Hey all,

Honestly I have no idea what this is all about, but saw something in the
change adding "ipf->if_flags=LINK_STATE_UP;" that just seemed really strange
from a programming standpoint. Doesn't this statement "undo" the effects of
the line just before it (ipf->if_flags |= IFF_RUNNING).

Again I have no idea what this is about so it is possible that IFF_RUNNING
bit(s) is part of LINK_STATE_UP bit(s). Just seemed strange and if this is a
problem, catching it early is better than late.

If it is correct as stands, I apologize for questioning it.

Mike Smith


>----- Original Message ----- 
>From: "Josh Kayse" <josh.kayse@gmail.com>
>
> One last comment,
>
> I managed to fix it so that carp runs on the plip interface by adding:
> ifp->if_flags = LINK_STATE_UP;

> Here is the diff:

> diff -Nur /usr.orig/src/sys/dev/ppbus/if_plip.c
/usr/src/sys/dev/ppbus/if_plip.c
> --- /usr.orig/src/sys/dev/ppbus/if_plip.c       Wed Sep 15 11:14:18 2004
> +++ /usr/src/sys/dev/ppbus/if_plip.c    Mon Jun 13 10:05:56 2005
> @@ -359,6 +359,7 @@
>
>             ppb_wctr(ppbus, IRQENABLE);
>             ifp->if_flags |= IFF_RUNNING;
> +           ifp->if_flags = LINK_STATE_UP;
>         }
>         break;