From owner-freebsd-net Wed Oct 11 1:53:45 2000 Delivered-To: freebsd-net@freebsd.org Received: from shuttle.wide.toshiba.co.jp (shuttle.wide.toshiba.co.jp [202.249.10.124]) by hub.freebsd.org (Postfix) with ESMTP id 1181C37B503; Wed, 11 Oct 2000 01:53:40 -0700 (PDT) Received: from localhost ([3ffe:501:100f:10c1:250:4ff:fefe:d85f]) by shuttle.wide.toshiba.co.jp (8.9.1+3.1W/8.9.1) with ESMTP id RAA23001; Wed, 11 Oct 2000 17:38:07 +0900 (JST) Date: Wed, 11 Oct 2000 17:52:23 +0900 Message-ID: From: JINMEI Tatuya / =?ISO-2022-JP?B?GyRCP0BMQEMjOkgbKEI=?= To: Ruslan Ermilov Cc: itojun@iijlab.net, Luigi Rizzo , Archie Cobbs , bmilekic@FreeBSD.ORG, freebsd-net@FreeBSD.ORG, Garrett Wollman Subject: Re: ip_input.c patch In-Reply-To: In your message of "Wed, 11 Oct 2000 11:01:32 +0300" <20001011110132.D56373@sunbay.com> References: <200010110529.HAA85814@info.iet.unipi.it> <23730.971250366@coconut.itojun.org> <20001011110132.D56373@sunbay.com> User-Agent: Wanderlust/2.3.0 (Roam) Emacs/20.7 Mule/4.0 (HANANOEN) Organization: Research & Development Center, Toshiba Corp., Kawasaki, Japan. MIME-Version: 1.0 (generated by SEMI 1.13.7 - "Awazu") Content-Type: text/plain; charset=US-ASCII X-Dispatcher: imput version 980905(IM100) Lines: 18 Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org >>>>> On Wed, 11 Oct 2000 11:01:32 +0300, >>>>> Ruslan Ermilov said: >> while i 100% agree that we should not swap bytes in ip_input, >> we need to be very sure to preserve (strange) byte ordering constraint >> in raw ip socket (IP_HDRINCL)... so be careful. >> > If noone objects, I will prepare the patch that avoids byte-swapping for > ip_len and ip_off (I have recently done a similar thing for ip_id). I don't necessarily object to the change, but we'll also have to note about the change will affect some part of kernel IPsec code (at least ah4_input() defined in netinet6/ah_input.c). JINMEI, Tatuya Communication Platform Lab. Corporate R&D Center, Toshiba Corp. jinmei@isl.rdc.toshiba.co.jp To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message