From owner-cvs-all Tue Dec 12 12:18:12 2000 From owner-cvs-all@FreeBSD.ORG Tue Dec 12 12:18:06 2000 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from netau1.alcanet.com.au (ntp.alcanet.com.au [203.62.196.27]) by hub.freebsd.org (Postfix) with ESMTP id F3F9937B400; Tue, 12 Dec 2000 12:18:04 -0800 (PST) Received: from mfg1.cim.alcatel.com.au (mfg1.cim.alcatel.com.au [139.188.23.1]) by netau1.alcanet.com.au (8.9.3 (PHNE_18979)/8.9.3) with ESMTP id HAA19866; Wed, 13 Dec 2000 07:18:01 +1100 (EDT) Received: from gsmx07.alcatel.com.au by cim.alcatel.com.au (PMDF V5.2-32 #37640) with ESMTP id <01JXNBAXHVY8907XD9@cim.alcatel.com.au>; Wed, 13 Dec 2000 07:17:59 +1100 Received: (from jeremyp@localhost) by gsmx07.alcatel.com.au (8.11.0/8.11.0) id eBCKHw584168; Wed, 13 Dec 2000 07:17:58 +1100 (EST envelope-from jeremyp) Content-return: prohibited Date: Wed, 13 Dec 2000 07:17:58 +1100 From: Peter Jeremy Subject: Re: cvs commit: src/sys/sys kernel.h eventhandler.h src/sys/kern subr_eventhandler.c In-reply-to: <200012120401.eBC41ZZ28700@freefall.freebsd.org>; from jhb@FreeBSD.ORG on Mon, Dec 11, 2000 at 08:01:35PM -0800 To: John Baldwin Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Mail-followup-to: John Baldwin , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-id: <20001213071758.R69646@gsmx07.alcatel.com.au> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline User-Agent: Mutt/1.2.5i References: <200012120401.eBC41ZZ28700@freefall.freebsd.org> Sender: jeremyp@gsmx07.alcatel.com.au Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 2000-Dec-11 20:01:35 -0800, John Baldwin wrote: >jhb 2000/12/11 20:01:35 PST > > Modified files: > sys/sys kernel.h eventhandler.h > sys/kern subr_eventhandler.c > Log: > - Convert the per-eventhandler list mutex to a lockmgr lock so that it can > be safely held across an eventhandler function call. > - Fix an instance of the head of an eventhandler list being read without > the lock being held. > - Break down and use a SYSINIT at the new SI_SUB_EVENTHANDLER to initialize > the eventhandler global mutex and the eventhandler list of lists rather > than using a non-MP safe initialization during the first call to > eventhandler_register(). > - Add in a KASSERT() to eventhandler_register() to ensure that we don't try > to register an eventhandler before things have been initialized. > > Revision Changes Path > 1.75 +2 -1 src/sys/sys/kernel.h > 1.15 +9 -11 src/sys/sys/eventhandler.h I think change to eventhandler.h has broken the agp module build: ===> agp cc -O -pipe -D_KERNEL -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -DKLD_MODULE -nostdinc -I- -I. -I@ -I@/dev -I@/../include -mpreferred-stack-boundary=2 -c /3.0/cvs/src/sys/modules/agp/../../pci/agp.c /3.0/cvs/src/sys/modules/agp/../../pci/agp.c: In function `agp_generic_detach': /3.0/cvs/src/sys/modules/agp/../../pci/agp.c:272: `curproc' undeclared (first use in this function) /3.0/cvs/src/sys/modules/agp/../../pci/agp.c:272: (Each undeclared identifier is reported only once /3.0/cvs/src/sys/modules/agp/../../pci/agp.c:272: for each function it appears in.) /3.0/cvs/src/sys/modules/agp/../../pci/agp.c: In function `agp_generic_bind_memory': /3.0/cvs/src/sys/modules/agp/../../pci/agp.c:391: `curproc' undeclared (first use in this function) /3.0/cvs/src/sys/modules/agp/../../pci/agp.c: In function `agp_generic_unbind_memory': /3.0/cvs/src/sys/modules/agp/../../pci/agp.c:485: `curproc' undeclared (first use in this function) *** Error code 1 Stop in /3.0/cvs/src/sys/modules/agp. *** Error code 1 Stop in /3.0/cvs/src/sys/modules. *** Error code 1 Stop in /usr/obj/3.0/cvs/src/sys/gsmx. *** Error code 1 Stop in /3.0/cvs/src. *** Error code 1 Stop in /3.0/cvs/src. My reasoning is: - agp.c compiled on Monday night. - According to the following: # cd /sys/modules/agp # make 'CC=cc -E -dD -C' |fgrep '$FreeBSD' | sort -b +4|less The only files that have changed recently are * $FreeBSD: src/sys/sys/eventhandler.h,v 1.15 2000/12/12 04:01:34 jhb Exp $ * $FreeBSD: src/sys/sys/kernel.h,v 1.75 2000/12/12 04:01:34 jhb Exp $ The latter just changes a #define, so I presume it's the change -#include +#include in eventhandler.h. Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message