Date: Wed, 13 Dec 2000 07:17:58 +1100 From: Peter Jeremy <peter.jeremy@alcatel.com.au> To: John Baldwin <jhb@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/sys kernel.h eventhandler.h src/sys/kern subr_eventhandler.c Message-ID: <20001213071758.R69646@gsmx07.alcatel.com.au> In-Reply-To: <200012120401.eBC41ZZ28700@freefall.freebsd.org>; from jhb@FreeBSD.ORG on Mon, Dec 11, 2000 at 08:01:35PM -0800 References: <200012120401.eBC41ZZ28700@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2000-Dec-11 20:01:35 -0800, John Baldwin <jhb@FreeBSD.ORG> wrote: >jhb 2000/12/11 20:01:35 PST > > Modified files: > sys/sys kernel.h eventhandler.h > sys/kern subr_eventhandler.c > Log: > - Convert the per-eventhandler list mutex to a lockmgr lock so that it can > be safely held across an eventhandler function call. > - Fix an instance of the head of an eventhandler list being read without > the lock being held. > - Break down and use a SYSINIT at the new SI_SUB_EVENTHANDLER to initialize > the eventhandler global mutex and the eventhandler list of lists rather > than using a non-MP safe initialization during the first call to > eventhandler_register(). > - Add in a KASSERT() to eventhandler_register() to ensure that we don't try > to register an eventhandler before things have been initialized. > > Revision Changes Path > 1.75 +2 -1 src/sys/sys/kernel.h > 1.15 +9 -11 src/sys/sys/eventhandler.h I think change to eventhandler.h has broken the agp module build: ===> agp cc -O -pipe -D_KERNEL -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -DKLD_MODULE -nostdinc -I- -I. -I@ -I@/dev -I@/../include -mpreferred-stack-boundary=2 -c /3.0/cvs/src/sys/modules/agp/../../pci/agp.c /3.0/cvs/src/sys/modules/agp/../../pci/agp.c: In function `agp_generic_detach': /3.0/cvs/src/sys/modules/agp/../../pci/agp.c:272: `curproc' undeclared (first use in this function) /3.0/cvs/src/sys/modules/agp/../../pci/agp.c:272: (Each undeclared identifier is reported only once /3.0/cvs/src/sys/modules/agp/../../pci/agp.c:272: for each function it appears in.) /3.0/cvs/src/sys/modules/agp/../../pci/agp.c: In function `agp_generic_bind_memory': /3.0/cvs/src/sys/modules/agp/../../pci/agp.c:391: `curproc' undeclared (first use in this function) /3.0/cvs/src/sys/modules/agp/../../pci/agp.c: In function `agp_generic_unbind_memory': /3.0/cvs/src/sys/modules/agp/../../pci/agp.c:485: `curproc' undeclared (first use in this function) *** Error code 1 Stop in /3.0/cvs/src/sys/modules/agp. *** Error code 1 Stop in /3.0/cvs/src/sys/modules. *** Error code 1 Stop in /usr/obj/3.0/cvs/src/sys/gsmx. *** Error code 1 Stop in /3.0/cvs/src. *** Error code 1 Stop in /3.0/cvs/src. My reasoning is: - agp.c compiled on Monday night. - According to the following: # cd /sys/modules/agp # make 'CC=cc -E -dD -C' |fgrep '$FreeBSD' | sort -b +4|less The only files that have changed recently are * $FreeBSD: src/sys/sys/eventhandler.h,v 1.15 2000/12/12 04:01:34 jhb Exp $ * $FreeBSD: src/sys/sys/kernel.h,v 1.75 2000/12/12 04:01:34 jhb Exp $ The latter just changes a #define, so I presume it's the change -#include <sys/mutex.h> +#include <sys/lock.h> in eventhandler.h. Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001213071758.R69646>