From owner-svn-src-all@freebsd.org Mon Aug 10 00:16:13 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C16EF99E5E6 for ; Mon, 10 Aug 2015 00:16:13 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from vfemail.net (ninezero.vfemail.net [96.30.253.190]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 843F5DA9 for ; Mon, 10 Aug 2015 00:16:12 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: (qmail 3856 invoked by uid 89); 10 Aug 2015 00:16:00 -0000 Received: from localhost (HELO freequeue.vfemail.net) (127.0.0.1) by localhost with (DHE-RSA-AES256-SHA encrypted) SMTP; 10 Aug 2015 00:16:00 -0000 Received: (qmail 3836 invoked by uid 89); 10 Aug 2015 00:15:43 -0000 Received: by simscan 1.3.1 ppid: 3827, pid: 3832, t: 0.0041s scanners:none Received: from unknown (HELO smtp102-2.vfemail.net) (172.16.100.62) by FreeQueue with SMTP; 10 Aug 2015 00:15:43 -0000 Received: (qmail 6843 invoked by uid 89); 10 Aug 2015 00:15:43 -0000 Received: by simscan 1.4.0 ppid: 6826, pid: 6840, t: 0.5497s scanners:none Received: from unknown (HELO nil) (amJlaWNoQHZmZW1haWwubmV0@172.16.100.27) by 172.16.100.62 with ESMTPA; 10 Aug 2015 00:15:42 -0000 From: Jan Beich To: Koop Mast Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r286524 - in head: . etc sys/dev/drm sys/dev/drm2 References: <201508091258.t79CwvGj027161@repo.freebsd.org> Date: Mon, 10 Aug 2015 02:15:23 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2015 00:16:13 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Koop Mast writes: > Author: kwm (ports committer) > Date: Sun Aug 9 12:58:56 2015 > New Revision: 286524 > URL: https://svnweb.freebsd.org/changeset/base/286524 > > Log: > Add a new group named 'video' with the id of 44. And make drm create > devices in /dev/dri/ with this new group. Would 'video' group include capture devices as well? Linux seems to mix /dev/nvidia*, /dev/fb* and /dev/video* all under same group despite all of them have different attack vectors. > Modified: head/sys/dev/drm/drmP.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/dev/drm/drmP.h Sun Aug 9 12:20:22 2015 (r286523) > +++ head/sys/dev/drm/drmP.h Sun Aug 9 12:58:56 2015 (r286524) > @@ -175,7 +175,7 @@ SYSCTL_DECL(_hw_drm); >=20=20 > #define DRM_DEV_MODE (S_IRUSR|S_IWUSR|S_IRGRP|S_IWGRP) > #define DRM_DEV_UID 0 > -#define DRM_DEV_GID 0 > +#define DRM_DEV_GID 44 /* "video" group */ Why hardcode? Linux often uses udev(7) rules to assign a group which on FreeBSD can easily be translated into devd.conf(5) or devfs.rules(5). Having 'video' assigned by kernel wouldn't eliminate having to run mergemaster/etcupdate + pw groupmod on upgrade. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJVx+0cXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3b39sIAImStOX28KsCCLS6BrNsknao WyYm2D7LU+tJFgja4GKvcUld7Iw7v+NjQik11aF+rPpv7fGKe1oI5+5Hk7ttuQDt 8++AvdHj7Yl+8J0918gXBlWyYrEbdIT/7BxRlcRrgLgMiB6iFHDYbYy8heMhlwpw 9/a6ptEdTE1Ky7GqBFjtag09Wn3toI6ZdXmp/J/BBzJ6Ifvy4ILGZR9mpkK+24UY 5cyQ4UXAfFShiGqS748s+FYWEUxc3lazzP/48G7nQg6UfVfhqoFj0s66NNupuLfS 56axP72kGFErt3g5FipInTyFyD6h/D23KfzsL0lPdnFlFvQwLx5kBGKIAVmLeG8= =KBTO -----END PGP SIGNATURE----- --=-=-=--