From owner-freebsd-arm@FreeBSD.ORG  Thu Dec  6 22:07:37 2007
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E3DF316A417
	for <freebsd-arm@freebsd.org>; Thu,  6 Dec 2007 22:07:37 +0000 (UTC)
	(envelope-from mlfbsd@dong.ci0.org)
Received: from dong.ci0.org (dong.ci0.org [IPv6:2001:7a8:2066:1::1])
	by mx1.freebsd.org (Postfix) with ESMTP id 3914F13C44B
	for <freebsd-arm@freebsd.org>; Thu,  6 Dec 2007 22:07:36 +0000 (UTC)
	(envelope-from mlfbsd@dong.ci0.org)
Received: from dong.ci0.org (localhost.ci0.org [127.0.0.1])
	by dong.ci0.org (8.14.1/8.13.8) with ESMTP id lB6N4IPf007401;
	Fri, 7 Dec 2007 00:04:18 +0100 (CET)
	(envelope-from mlfbsd@dong.ci0.org)
Received: (from mlfbsd@localhost)
	by dong.ci0.org (8.14.1/8.13.8/Submit) id lB6N4IoX007398;
	Fri, 7 Dec 2007 00:04:18 +0100 (CET) (envelope-from mlfbsd)
Date: Fri, 7 Dec 2007 00:04:18 +0100
From: Olivier Houchard <mlfbsd@ci0.org>
To: Mark Tinguely <tinguely@casselton.net>
Message-ID: <20071206230417.GA7366@ci0.org>
References: <200712062158.lB6LwL1D089098@casselton.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200712062158.lB6LwL1D089098@casselton.net>
User-Agent: Mutt/1.4.1i
Cc: freebsd-arm@freebsd.org
Subject: Re: ARM pmap_enter_pv question
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the StrongARM Processor <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Dec 2007 22:07:38 -0000

On Thu, Dec 06, 2007 at 03:58:21PM -0600, Mark Tinguely wrote:
> 
> in pmap_enter_pv(), it seems to me there is an "else" missing:
> 
> 	if (pm == pmap_kernel()) {
> 		if (flags & PVF_WRITE)
> 			pg->md.krw_mappings++;
> 		else
> 			pg->md.kro_mappings++;
> 	}					<<<< is there a "else" missing?
> 	if (flags & PVF_WRITE)
> 		pg->md.urw_mappings++;
> 	else
> 		pg->md.uro_mappings++;
> 
> I don't think it will effect any caching settings.
> 

You're right, I wonder where this else went, it must have been there, 
because this code comes from NetBSD, and NetBSD has it.

Thanks a lot !

Olivier