From owner-svn-ports-head@freebsd.org  Mon Jan 25 08:56:54 2016
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6BBE59D92AE;
 Mon, 25 Jan 2016 08:56:54 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 6297085A;
 Mon, 25 Jan 2016 08:56:54 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 6089C1E7E; Mon, 25 Jan 2016 08:56:54 +0000 (UTC)
Date: Mon, 25 Jan 2016 08:56:54 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: John Marino <marino@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r406930 - head/archivers/file-roller
Message-ID: <20160125085654.GB95732@FreeBSD.org>
References: <201601221319.u0MDJbbm075196@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201601221319.u0MDJbbm075196@repo.freebsd.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Jan 2016 08:56:54 -0000

On Fri, Jan 22, 2016 at 01:19:37PM +0000, John Marino wrote:
> New Revision: 406930
> URL: https://svnweb.freebsd.org/changeset/ports/406930
> 
> Log:
>   archivers/file_roller: Fix ambiguous RUN_DEPENDS
>   
>   file_roller requires the ports version of unzip (I'm assuming based on
>   makefile's specifications).  However, since the full path to unzip
>   was not specified, the base unzip satifies the requirement which results
>   in the archivers/unzip package not being registered as a run dependency.
>  
> [...]
>  RUN_DEPENDS=	gtar:${PORTSDIR}/archivers/gtar \
> -    		unzip:${PORTSDIR}/archivers/unzip
> +    		zipinfo:${PORTSDIR}/archivers/unzip
> +
> +# Port unzip is desired, but specify the uniquely named zipinfo to ensure
> +# archivers/unzip is pulled in.  Using "unzip" is satisfied by base unzip

Another option would be to specify full path of unzip(1), i.e.
${LOCALBASE}/bin/unzip:...  This would also reflect the reality, since if
base unzip(1) is not sufficient beyond trivial usecases (which is probably
the reason why `archivers/file-roller' wants "real" unzip -- e.g. the one
that support encrypted archives and stuff).

Also, "port unzip" reads a bit weird in that comment (cf. "unzip from [the]
ports"), but IMHO specifying full path is 1) more correct, and 2) would not
require such elaborate comment.

You've also introduced trailing whitespace there (in addition to the one in
pkg-descr, existing prior to this commit).

./danfe