Date: Fri, 31 Mar 2023 10:30:52 -0400 From: Adam Weinberger <adamw@adamw.org> To: Guido Falsi <madpilot@freebsd.org> Cc: gmarco@giovannelli.it, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: de841b40d24d - main - sysutils/xxd: New port Message-ID: <440103A8-A773-4B4E-BEB1-28C49D1B9CB5@adamw.org> In-Reply-To: <03eb85e1-14fa-24f4-dcb3-84caeef82a24@FreeBSD.org> References: <03eb85e1-14fa-24f4-dcb3-84caeef82a24@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Mar 31, 2023, at 10:28, Guido Falsi <madpilot@freebsd.org> wrote: >=20 > =EF=BB=BFOn 31/03/23 15:49, Adam Weinberger wrote: >> On Thu, Mar 30, 2023 at 4:45=E2=80=AFPM Guido Falsi <madpilot@freebsd.org= <mailto:madpilot@freebsd.org>> wrote: >> The branch main has been updated by madpilot: >> URL: >> https://cgit.FreeBSD.org/ports/commit/?id=3Dde841b40d24d22ab51ad05ed63= 2e025903fbb41f <https://cgit.FreeBSD.org/ports/commit/?id=3Dde841b40d24d22ab= 51ad05ed632e025903fbb41f> >> commit de841b40d24d22ab51ad05ed632e025903fbb41f >> Author: Guido Falsi <madpilot@FreeBSD.org> >> AuthorDate: 2023-03-30 20:42:54 +0000 >> Commit: Guido Falsi <madpilot@FreeBSD.org> >> CommitDate: 2023-03-30 20:42:54 +0000 >> sysutils/xxd: New port >> This is the standalone version of the xxd tool provided by vim. >> Submitted by: Gianmarco Giovannelli <gmarco@giovannelli.it >> <mailto:gmarco@giovannelli.it>> >> diff --git a/sysutils/xxd/Makefile b/sysutils/xxd/Makefile >> new file mode 100644 >> index 000000000000..378f364cf4bf >> --- /dev/null >> +++ b/sysutils/xxd/Makefile >> @@ -0,0 +1,26 @@ >> +PORTNAME=3D xxd >> +DISTVERSIONPREFIX=3D v >> +DISTVERSION=3D 9.0.1366 >> +CATEGORIES=3D sysutils >> + >> +MAINTAINER=3D gmarco@giovannelli.it <mailto:gmarco@giovannelli.it> >> +COMMENT=3D Hexdump and reverse hexdump utility >> +WWW=3D https://github.com/mew-cx/xxd <https://github.com/mew-cx/xxd>; >> + >> +CONFLICTS_INSTALL=3D vim-[0-9]* vim-gtk2 vim-gtk3 vim-motif vim-x= 11 >> + >> +ALL_TARGET=3D ${PORTNAME} >> +PORTSCOUT=3D ignore:1 >> +EXTRACT_AFTER_ARGS=3D --include=3D'*/src/xxd*' >> +WRKSRC_SUBDIR=3D src/xxd >> + >> +PLIST_FILES=3D bin/xxd >> + >> +USE_GITHUB=3D yes >> +GH_ACCOUNT=3D vim >> +GH_PROJECT=3D vim >> + >> +do-install: >> + ${INSTALL_PROGRAM} ${WRKSRC}/xxd ${STAGEDIR}${PREFIX}/bin >> + >> +.include <bsd.port.mk <http://bsd.port.mk>>; >> The WWW is odd here. The source files are coming from github.com/vim/vim <= http://github.com/vim/vim>, but the WWW is for a related but unused project.= >=20 > Oops, you're right. Submitter proposed to use a fork, but later I decided g= rabbing the original vim distribution was better, I must have forgotten upda= ting the WWW line. >=20 > Will fix it! >=20 >> I update vim at the beginning of every month plus whenever new minors are= released, and whenever there are patches that it's important for us to down= stream. Rather than pinning xxd to a version that will be old literally tomo= rrow, why not pull the DISTVERSION and distinfo from editors/vim/Makefile? >=20 > That would be a good idea, but while using vim distinfo is trivial, I'm no= t sure how to import DISTVERSION from another port. Including the Makefile w= ould override a bunch of other variables. ${MAKE_CMD} -V DISTVERSION :-) =E2=80=94 Adam Weinberger adamw@adamw.org https://www.adamw.org >=20 > --=20 > Guido Falsi <madpilot@FreeBSD.org> >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?440103A8-A773-4B4E-BEB1-28C49D1B9CB5>