Date: Sun, 22 Mar 2015 23:51:23 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r381980 - head Message-ID: <550F9BCB.5080004@FreeBSD.org> In-Reply-To: <201503230408.t2N48SZH015518@svn.freebsd.org> References: <201503230408.t2N48SZH015518@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RkfHEI8DXvg11TOTNpQqdcHr4lC1aw3xB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 3/22/2015 11:08 PM, Bryan Drewery wrote: > Author: bdrewery > Date: Mon Mar 23 04:08:27 2015 > New Revision: 381980 > URL: https://svnweb.freebsd.org/changeset/ports/381980 > QAT: https://qat.redports.org/buildarchive/r381980/ >=20 > Log: > Undocument BSDMAKE from r381977 as I have thought of a better way and= will > likely revert it. > =20 > With hat: portmgr >=20 > Modified: > head/CHANGES >=20 > Modified: head/CHANGES > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/CHANGES Mon Mar 23 04:07:08 2015 (r381979) > +++ head/CHANGES Mon Mar 23 04:08:27 2015 (r381980) > @@ -10,13 +10,6 @@ in the release notes and/or placed into=20 > =20 > All ports committers are allowed to commit to this file. > =20 > -20150322: > - AUTHOR: bdrewery@FreeBSD.org > - > - There is now a BSDMAKE that can be overriden for the location of > - /usr/bin/make. It is a safer alternative to overriding MAKE_CMD whic= h > - will be force reset for gmake/fmake/scons ports. > - > 20150319: > AUTHOR: bdrewery@FreeBSD.org > =20 >=20 I feel the need to define BSDMAKE still but don't like that it is not just MAKE_CMD since that is what has been advertised for so long. MAKE_CMD currently has 2 uses. Both the default /usr/bin/make location and the make that is used to interact with a port's distribution Makefile. When using USES=3Dgmake for example MAKE_CMD becomes gmake. There then is no way to define what the default make was (/usr/bin/make) if it is still needed. =46rom sometime last year until r381976 a user setting MAKE_CMD would not= be able to build gmake/scons/fmake ports. What I am trying to do is interact with the ports tree with bmake but build ports with fmake. Bmake does not work with the /usr/share/mk on 8.4/9.3 but it works fine with the ports tree. Any actual Makefile with real object targets it encounters hits a 'dirsyntax' error and fails. So I am trying to ensure that ports are respecting MAKE_CMD and building with my override of /usr/bin/fmake since I have made /usr/bin/make into bmake. This idea may grow into a bootstrapped bmake so 8.4 does not instantly break on EOL day. I don't know if I will take it that far. This is why I have added BSDMAKE and switched to it in the qemu ports in r381978 since they have USES=3Dgmake and get a MAKE_CMD=3Dgmake. MAKE is bmake in my use. I insist that using ${MAKE} to build a port's distribution files is just fundamentally wrong; it should only be used to interact recursively with the framework. This port was nice enough to spell out that it needs a real bsd make to build. It may even work with gmake at this point but I did not test. Incidentally I have been finding a lot interesting bugs with MAKE_CMD usage. Some ports claim to need gmake but are accidentally using bsdmake in the middle of their build. It has just worked by accident. I imagine that fixing these to properly use MAKE_CMD (hence gmake) will improve parallel builds as well. So my alternative idea for BSDMAKE was to mass replace MAKE_CMD with _MAKE_CMD in ports and then keep MAKE_CMD to mean /usr/bin/make. I'm not sure which route should be taken. --=20 Regards, Bryan Drewery --RkfHEI8DXvg11TOTNpQqdcHr4lC1aw3xB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVD5vMAAoJEDXXcbtuRpfP2N4IAN0zvRbxr27uWyLGvzUvILLo yBLg8ZED7OMkts0RyhtsRvRUW0i3yp45QMIfRdwBOBiT9m6kBJe4M1eGAtY3jCMp CYeiumBvad7AVCENz7U2bwzczqZxLYeJwSsIDtrMYLpvGefz8qHTGIPUywzsA8SZ OoFAwIw2brKWUPoP6HKEZCMQTJrntWDJMqRvtD3yay5M6GpZLbBTHq3EUAdm9V4T IUq1NaweVeNMDcryck/W8ahiyrCEsVI7aPx4NsG5D7GoxmirWUdP1QMHhQ/UHyo8 FogD08S0NVWhmN0B6no5v79qBjqqduzUrpBgn2fV7HHnYvKETqJcpwQ8Pm7ClZU= =RcrW -----END PGP SIGNATURE----- --RkfHEI8DXvg11TOTNpQqdcHr4lC1aw3xB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?550F9BCB.5080004>