From owner-freebsd-current Sun Oct 1 15:16:27 2000 Delivered-To: freebsd-current@freebsd.org Received: from c1030098-a.wtrlo1.ia.home.com (c1030098-a.wtrlo1.ia.home.com [24.11.39.39]) by hub.freebsd.org (Postfix) with ESMTP id 5E43C37B66C for ; Sun, 1 Oct 2000 15:16:25 -0700 (PDT) Received: (from mdharnois@localhost) by c1030098-a.wtrlo1.ia.home.com (8.11.0/8.11.0) id e91MGPP66217; Sun, 1 Oct 2000 17:16:25 -0500 (CDT) (envelope-from mdharnois@home.com) X-Authentication-Warning: mharnois.workgroup.net: mdharnois set sender to mdharnois@home.com using -f To: current@FreeBSD.ORG Subject: Re: Today -current broken on build Keywords: fix,commit References: <9417.970426445@winston.osd.bsdi.com> <200010011914.e91JEPh03548@mass.osd.bsdi.com> <20001001124716.A96755@dragon.nuxi.com> From: Michael Harnois Date: 01 Oct 2000 17:16:25 -0500 In-Reply-To: <20001001124716.A96755@dragon.nuxi.com> Message-ID: <86itrcgqbq.fsf@mharnois.workgroup.net> Lines: 32 User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.2 (Nike) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG This is better than watching the soaps. I'll be waiting anxiously for the next installment. ;<) On Sun, 1 Oct 2000 12:47:16 -0700, "David O'Brien" said: > On Sun, Oct 01, 2000 at 12:14:25PM -0700, Mike Smith wrote: >> > > I hate to spoil the moment ... but does anyone have an idea >> what the > > fix is? Nothing in the amd directory seems to >> have changed in the > > past couple of weeks, so it must be >> somewhere else, and I'm not bright > > enough to figure out >> where. > > Yeah, somebody forgot that typedefs and structure >> names can't > conflict. :) I've just committed the fix. >> >> Er, this is probably the wrong fix. It sounds like the kernel >> 'callout' structure is ending up visible in userland, which it >> shouldn't. > This commit also took a file off the vendor branch and the > maintainer of src/contrib was not consulted. > The committer that committed something w/o testing `make world' > should have backed out their commit and then discussed that they > wanted a change made in Amd or taken a different approach in > their commit. > -- -- David (obrien@FreeBSD.org) -- Michael D. Harnois, Redeemer Lutheran Church, Washburn, IA mdharnois@home.com aa0bt@aa0bt.ampr.org "Doing bad things is not evangelism." -- Ann Hafften To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message