From owner-freebsd-audit  Sat Jul 14  8:52:41 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from coffee.q9media.com (coffee.q9media.com [216.94.229.19])
	by hub.freebsd.org (Postfix) with ESMTP
	id A59B537B407; Sat, 14 Jul 2001 08:52:39 -0700 (PDT)
	(envelope-from mike@coffee.q9media.com)
Received: (from mike@localhost)
	by coffee.q9media.com (8.11.2/8.11.2) id f6EG8bh28861;
	Sat, 14 Jul 2001 12:08:37 -0400 (EDT)
	(envelope-from mike)
Date: Sat, 14 Jul 2001 12:08:37 -0400 (EDT)
Message-Id: <200107141608.f6EG8bh28861@coffee.q9media.com>
From: Mike Barcroft <mike@q9media.com>
To: "Andrey A. Chernov" <ache@nagual.pp.ru>
Cc: jkh@freebsd.org, audit@freebsd.org
Subject: Re: CFR: add /etc/ttys console tuning to sysinstall
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

In configTtys():
[...]
> +    char templ[20];
[...]
> +    strcpy(templ, _PATH_TTYS ".XXXXXX");
[...]

This makes the assumption that _PATH_TTYS is < 13.  Maybe you should
do something like:

#define _X_EXTENTION ".XXXXXX"
char templ[sizeof(_PATH_TTYS) + sizeof(_X_EXTENTION) - 1];
strcpy(templ, _PATH_TTYS _X_EXTENTION);

Or you could use strlcpy(3) to be paranoid.


Best regards,
Mike Barcroft

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message