From owner-freebsd-bugs@FreeBSD.ORG Wed Jul 13 22:10:18 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A333916A41C for ; Wed, 13 Jul 2005 22:10:18 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 293B943D49 for ; Wed, 13 Jul 2005 22:10:18 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j6DMAHpq031232 for ; Wed, 13 Jul 2005 22:10:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j6DMAHje031231; Wed, 13 Jul 2005 22:10:17 GMT (envelope-from gnats) Resent-Date: Wed, 13 Jul 2005 22:10:17 GMT Resent-Message-Id: <200507132210.j6DMAHje031231@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Lukes Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A030716A41C for ; Wed, 13 Jul 2005 22:02:36 +0000 (GMT) (envelope-from dan@kulesh.obluda.cz) Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243]) by mx1.FreeBSD.org (Postfix) with ESMTP id C454943D48 for ; Wed, 13 Jul 2005 22:02:35 +0000 (GMT) (envelope-from dan@kulesh.obluda.cz) Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1]) by kulesh.obluda.cz (8.13.3/8.13.3) with ESMTP id j6DM2XfT025409 for ; Thu, 14 Jul 2005 00:02:33 +0200 (CEST) (envelope-from dan@kulesh.obluda.cz) Received: (from root@localhost) by kulesh.obluda.cz (8.13.3/8.13.1/Submit) id j6DM2WW2025408; Thu, 14 Jul 2005 00:02:32 +0200 (CEST) (envelope-from dan) Message-Id: <200507132202.j6DM2WW2025408@kulesh.obluda.cz> Date: Thu, 14 Jul 2005 00:02:32 +0200 (CEST) From: Dan Lukes To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/83419: [ PATCH ] incorrect malloc failures handling within libstand X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dan Lukes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2005 22:10:18 -0000 >Number: 83419 >Category: bin >Synopsis: [ PATCH ] incorrect malloc failures handling within libstand >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jul 13 22:10:17 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD 5.4-STABLE i386 >Organization: Obludarium >Environment: System: FreeBSD 5.4-STABLE #8: Sat Jul 9 16:31:08 CEST 2005 i386 lib/libstand/environment.c,v 1.6 2003/10/26 04:04:12 peter >Description: Incorrect malloc failures handling within libstand environment handling >How-To-Repeat: >Fix: --- patch begins here --- --- lib/libstand/environment.c.ORIG Fri Nov 14 03:26:04 2003 +++ lib/libstand/environment.c Wed Jul 13 23:57:38 2005 @@ -82,7 +82,13 @@ * New variable; create and sort into list */ ev = malloc(sizeof(struct env_var)); + if (ev == NULL) + return(-1); ev->ev_name = strdup(name); + if (ev->name == NULL) { + freee(ev); + return(-1); + } ev->ev_value = NULL; /* hooks can only be set when the variable is instantiated */ ev->ev_sethook = sethook; --- patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: