From owner-svn-src-all@freebsd.org  Mon May 30 05:22:04 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 11188B54214;
 Mon, 30 May 2016 05:22:04 +0000 (UTC)
 (envelope-from julian@freebsd.org)
Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "vps1.elischer.org",
 Issuer "CA Cert Signing Authority" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id C7BE0173E;
 Mon, 30 May 2016 05:22:03 +0000 (UTC)
 (envelope-from julian@freebsd.org)
Received: from Julian-MBP3.local
 (ppp121-45-225-151.lns20.per1.internode.on.net [121.45.225.151])
 (authenticated bits=0)
 by vps1.elischer.org (8.15.2/8.15.2) with ESMTPSA id u4U5LtK4027730
 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);
 Sun, 29 May 2016 22:21:59 -0700 (PDT)
 (envelope-from julian@freebsd.org)
Subject: Re: svn commit: r299393 - in head: . share/mk
To: John Baldwin <jhb@freebsd.org>, Hans Petter Selasky <hps@selasky.org>
References: <201605102232.u4AMWNvp000287@repo.freebsd.org>
 <08cfa0ac-ad92-c8f9-2141-e72088b17d41@selasky.org>
 <6335113.N7gIF2Maer@ralph.baldwin.cx>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
From: Julian Elischer <julian@freebsd.org>
Message-ID: <c625e4d1-b1fe-7388-6f51-18983f5f6fbb@freebsd.org>
Date: Mon, 30 May 2016 13:21:50 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0)
 Gecko/20100101 Thunderbird/45.1.0
MIME-Version: 1.0
In-Reply-To: <6335113.N7gIF2Maer@ralph.baldwin.cx>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 30 May 2016 05:22:04 -0000

On 27/05/2016 2:28 AM, John Baldwin wrote:
> On Wednesday, May 25, 2016 03:27:07 PM Hans Petter Selasky wrote:
>> On 05/11/16 00:32, John Baldwin wrote:
>>> Author: jhb
>>> Date: Tue May 10 22:32:23 2016
>>> New Revision: 299393
>>> URL: https://svnweb.freebsd.org/changeset/base/299393
>>>
>>> Log:
>>>    Change the default installation directory for modules to /boot/modules.
>>>
>>>    Kernel installs always override KMODDIR when installing modules, so
>>>    this default setting is only used for standalone module builds.  Many
>>>    out-of-tree modules manually override KMODDIR already to avoid placing
>>>    modules in /boot/kernel.  This now makes that behavior the default.
>>>
>>>    Discussed on:	arch@
>>>    Reviewed by:	imp
>>>    Relnotes:	yes
>>>
>> Just a small nit:
>>
>> There is a comment in bsd.own.mk which needs updating too:
>>
>>> #
>>> # KMODDIR       Base path for loadable kernel modules
>>> #               (see kld(4)). [/boot/kernel]
> Oops, thanks.  Fixed.

the comment should also mention it does not cover in-tree modules.