From owner-freebsd-usb@FreeBSD.ORG Wed Mar 22 02:20:19 2006 Return-Path: X-Original-To: freebsd-usb@freebsd.org Delivered-To: freebsd-usb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5ABA816A401 for ; Wed, 22 Mar 2006 02:20:19 +0000 (UTC) (envelope-from iedowse@iedowse.com) Received: from nowhere.iedowse.com (nowhere.iedowse.com [82.195.144.75]) by mx1.FreeBSD.org (Postfix) with SMTP id 96F0143D53 for ; Wed, 22 Mar 2006 02:20:18 +0000 (GMT) (envelope-from iedowse@iedowse.com) Received: from localhost ([127.0.0.1] helo=iedowse.com) by nowhere.iedowse.com via local-iedowse id ; 22 Mar 2006 02:20:17 +0000 (GMT) To: Anish Mistry In-Reply-To: Your message of "Tue, 21 Mar 2006 15:10:10 EST." <200603211510.18064.mistry.7@osu.edu> Date: Wed, 22 Mar 2006 02:20:15 +0000 From: Ian Dowse Message-ID: <200603220220.aa96629@nowhere.iedowse.com> Cc: freebsd-usb@freebsd.org Subject: Re: [PATCH] Logitech USB Receiver mouse workaround patch X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2006 02:20:19 -0000 In message <200603211510.18064.mistry.7@osu.edu>, Anish Mistry writes: >I've just tested this and it works. It fixes the problem, rather than >hacking around it like the last commit to hid.c. >Ian, can you see that this makes it into 6.1? It's in -current now, thanks. I'll ask to MFC it in a few days - remind me again if you don't see it MFC'd soon. It looked ok based on a quick glance at the HID spec, and it didn't seem to cause any problems with 3 random mice I have here. A subtle difference between our hid.c and NetBSD's is that NetBSD's hid_report_size() doesn't add in the size of the extra report ID byte, so it has to compensate for it later - that explains the 'size += 8' that is in our code but not in NetBSD's. Ian