From owner-freebsd-net@FreeBSD.ORG Mon Aug 8 20:09:39 2005 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 18BC316A41F for ; Mon, 8 Aug 2005 20:09:39 +0000 (GMT) (envelope-from julian@elischer.org) Received: from delight.idiom.com (delight.idiom.com [216.240.32.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id CEB5B43D48 for ; Mon, 8 Aug 2005 20:09:38 +0000 (GMT) (envelope-from julian@elischer.org) Received: from idiom.com (idiom.com [216.240.32.1]) by delight.idiom.com (Postfix) with ESMTP id A7DF01F49D4; Mon, 8 Aug 2005 13:09:38 -0700 (PDT) Received: from [192.168.2.3] (home.elischer.org [216.240.48.38]) by idiom.com (8.12.11/8.12.11) with ESMTP id j78K9cxD084313; Mon, 8 Aug 2005 13:09:38 -0700 (PDT) (envelope-from julian@elischer.org) Message-ID: <42F7BC01.80102@elischer.org> Date: Mon, 08 Aug 2005 13:09:37 -0700 From: Julian Elischer User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.7) Gecko/20050424 X-Accept-Language: en, hu MIME-Version: 1.0 To: Ed Maste References: <20050808194648.GB4843@sandvine.com> In-Reply-To: <20050808194648.GB4843@sandvine.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-net@freebsd.org Subject: Re: [PATCH] Minor cleanup of inline declaration for netgraph.h X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Aug 2005 20:09:39 -0000 Ed Maste wrote: > We build one of our netgraph modules with -W, which causes GCC > to emit "warning: `inline' is not at beginning of declaration" for > netgraph.h. It's pretty trivial, but the attached patch cleans this > up so it's consistent across all of the functions in netgraph.h. committed to -current. Will MFC to other branches in 1 week if possible > > -- > Ed Maste, Sandvine Incorporated > > > ------------------------------------------------------------------------ > > Index: sys/netgraph/netgraph.h > =================================================================== > RCS file: /usr/cvs/src/sys/netgraph/netgraph.h,v > retrieving revision 1.58 > diff -u -3 -r1.58 netgraph.h > --- sys/netgraph/netgraph.h 2 Aug 2005 20:06:48 -0000 1.58 > +++ sys/netgraph/netgraph.h 8 Aug 2005 19:31:07 -0000 > @@ -175,7 +175,7 @@ > int line); > static __inline void _ng_hook_force_queue(hook_p hook, char * file, int line); > > -static void __inline > +static __inline void > _chkhook(hook_p hook, char *file, int line) > { > if (hook->hk_magic != HK_MAGIC) { > @@ -407,7 +407,7 @@ > > #ifdef NETGRAPH_DEBUG /*----------------------------------------------*/ > void dumpnode(node_p node, char *file, int line); > -static void __inline _chknode(node_p node, char *file, int line); > +static __inline void _chknode(node_p node, char *file, int line); > static __inline char * _ng_node_name(node_p node, char *file, int line); > static __inline int _ng_node_has_name(node_p node, char *file, int line); > static __inline ng_ID_t _ng_node_id(node_p node, char *file, int line); > @@ -425,7 +425,7 @@ > ng_fn_eachhook *fn, void *arg, char *file, int line); > static __inline void _ng_node_revive(node_p node, char *file, int line); > > -static void __inline > +static __inline void > _chknode(node_p node, char *file, int line) > { > if (node->nd_magic != ND_MAGIC) { > > > ------------------------------------------------------------------------ > > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"