From owner-cvs-sys  Thu Apr 11 00:46:25 1996
Return-Path: owner-cvs-sys
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id AAA19680
          for cvs-sys-outgoing; Thu, 11 Apr 1996 00:46:25 -0700 (PDT)
Received: from sequent.kiae.su (sequent.kiae.su [144.206.136.6])
          by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id AAA19638
          Thu, 11 Apr 1996 00:46:06 -0700 (PDT)
Received: by sequent.kiae.su id AA25211
  (5.65.kiae-2 ); Thu, 11 Apr 1996 10:33:12 +0300
Received: by sequent.KIAE.su (UUMAIL/2.0); Thu, 11 Apr 96 10:33:11 +0300
Received: (from ache@localhost) by astral.msk.su (8.7.5/8.7.3) id LAA01702; Thu, 11 Apr 1996 11:32:16 +0400 (MSD)
Message-Id: <199604110732.LAA01702@astral.msk.su>
Subject: Re: cvs commit:  src/sys/net slcompress.c
To: davidg@freefall.freebsd.org (David Greenman)
Date: Thu, 11 Apr 1996 11:32:15 +0400 (MSD)
Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org,
        cvs-sys@freefall.freebsd.org
In-Reply-To: <199604110646.XAA15145@freefall.freebsd.org> from "David Greenman" at "Apr 10, 96 11:46:26 pm"
From: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= (aka Andrey A. Chernov, Black Mage) <ache@astral.msk.su>
X-Class: Fast
X-Mailer: ELM [version 2.4ME+ PL15 (25)]
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-sys@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> davidg      96/04/10 23:46:26
> 
>   Modified:    sys/net   slcompress.c
>   Log:
>   When cslip gets an uncompressed packet, it attempts to save off the TCP/IP
>   header for use in decompressing subsequant packets. If cslip gets garbage
>   (such as what happens when there is a port speed mismatch or modem line
>   noise), it will occasionally mistake the packet as a valid uncompressed
>   packet. When it tries to save off the header, it doesn't bother to check
>   for the validity of the header length and will happily clobber not only
>   the cslip data structure, but parts of other kernel memory that happens
>   to follow it...causing, ahem, undesired behavior.

David, can you please also fix it in usr.sbin/ppp/slcompress.c?
(if the bug present there)

-- 
Andrey A. Chernov        : And I rest so composedly,  /Now, in my bed,
ache@astral.msk.su       : That any beholder  /Might fancy me dead -
http://dt.demos.su/~ache : Might start at beholding me,  /Thinking me dead.
RELCOM Team,FreeBSD Team :         E.A.Poe         From "For Annie" 1849