From owner-freebsd-ports@FreeBSD.ORG Fri Feb 1 11:31:06 2008 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2DB4216A468 for ; Fri, 1 Feb 2008 11:31:06 +0000 (UTC) (envelope-from tevans.uk@googlemail.com) Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.227]) by mx1.freebsd.org (Postfix) with ESMTP id BB1FC13C448 for ; Fri, 1 Feb 2008 11:31:05 +0000 (UTC) (envelope-from tevans.uk@googlemail.com) Received: by wr-out-0506.google.com with SMTP id 68so933456wri.3 for ; Fri, 01 Feb 2008 03:31:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer; bh=SyV26I1S71bSAEES3pMNk8VqTvjg2ktwSwpzbhax8rY=; b=HeWLjLBY5w75DKICWKrJ2s2IP0rt9GoA+6Kvnzt/6O5d6eiRhKK5c5BOShE30HCsC6kRBYE0Qx03+WCMQQHzzWZLTCYZcGplnfW1jz7fXoQYoFBw7PUvtI9mHp7ia2xsWBxQNzzCDjBUSVgkJRtMiKyMVb/dwakJX/a3eSAuxc4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer; b=e84/HcWgilDz7J4T13D92+n8LHldNJbMMIQH11VWjmozy0NRX8HvEJ03mftFRlM9nWdRyM2h9pwCUfsnfom0d6aQyPW0AViVr4oGZojU/aoc2GsgAtBCdMWIvW126o3nocN8f+xYlrBtktctkBwJTOEtQSWMhk5scnkOyIfiy3o= Received: by 10.150.96.10 with SMTP id t10mr1253859ybb.1.1201864001038; Fri, 01 Feb 2008 03:06:41 -0800 (PST) Received: from ?127.0.0.1? ( [217.206.187.79]) by mx.google.com with ESMTPS id m5sm14505957gve.11.2008.02.01.03.06.38 (version=SSLv3 cipher=RC4-MD5); Fri, 01 Feb 2008 03:06:40 -0800 (PST) From: Tom Evans To: "Chris H." In-Reply-To: <20080131184116.ennj4jbvw480ws8s@webmail.1command.com> References: <20080131184116.ennj4jbvw480ws8s@webmail.1command.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-WtyM75N87g73SYtmghG3" Date: Fri, 01 Feb 2008 11:06:36 +0000 Message-Id: <1201863996.2975.27.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.10.2 FreeBSD GNOME Team Port Cc: lstewart@freebsd.org, freebsd-apache@freebsd.org, freebsd-stable@freebsd.org, freebsd-ports@freebsd.org, Pete French Subject: Re: [: -le: argument expected X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2008 11:31:06 -0000 --=-WtyM75N87g73SYtmghG3 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2008-01-31 at 18:41 -0800, Chris H. wrote: >=20 > The cause is in the file: lang/php5/files/patch-Zend_zend_list.c >=20 > It accounts for all /3/ errors emitted during the initial portion > of the make process. The lines are as follows: >=20 > --- Zend/zend_list.c.orig 2007-01-01 10:35:46.000000000 +0100 > +++ Zend/zend_list.c 2008-01-29 11:05:14.000000000 +0100 > @@ -48,7 +48,7 @@ > return index; > } >=20 > -ZEND_API int _zend_list_delete(int id TSRMLS_DC) > +ZEND_API int _zend_list_delete(ulong id TSRMLS_DC) > { > *** zend_rsrc_list_entry *le; >=20 > @@ -65,7 +65,7 @@ > } >=20 >=20 > -ZEND_API void *_zend_list_find(int id, int *type TSRMLS_DC) > +ZEND_API void *_zend_list_find(ulong id, int *type TSRMLS_DC) > { > *** zend_rsrc_list_entry *le; >=20 > @@ -78,7 +78,7 @@ > } > } >=20 > -ZEND_API int _zend_list_addref(int id TSRMLS_DC) > +ZEND_API int _zend_list_addref(ulong id TSRMLS_DC) > { > *** zend_rsrc_list_entry *le; >=20 > (highlighted with three asterisks for clarity). >=20 > While it's nice that I found them. I'm not sure what to do to > make them correct. Any thoughts? Should I simply send-pr - > php5-apache-module build failure (lang/php5/files/patch-Zend_zend_list.c)= ? I doubt that patch is the issue. The error comes from a malformed call to /bin/test (or /bin/[ ). The -le test tests two numbers to see if the first is less than the second.=20 With correct usage: /bin/[ 5 -le 10 ] && echo "first is less" first is less With incorrect usage /bin/[ 5 -le ] && echo "first is less" [: -le: argument expected The patch you have shown changes the id of a zend_rsrc_list_entry to be an unsigned long rather than an int, the fact that the variable name (which does not get updated, modified or altered) is called 'le' for 'list element' is neither here nor there. I would thoroughly recommend using apache 2.2 with the prefork MPM if you wish to run PHP. Your arguments for choosing 2.0 over 2.2 are spurious, as there are virtually no difference in conf directives, server layout or security, where as apache 2.2 is well maintained and secure. Apache 2.2 has many notable improvements, especially in performance and proxying. See [1]. The real hint is on apache.org [2] - 'We consider Apache 2.2 to be the best available version at the time of this release. We offer Apache 2.0.63 as the best legacy version of Apache 2.0 available. Users should first consider upgrading to the current release of Apache 2.2 instead.' On the other hand, your server, your rules. :) Tom [1] http://httpd.apache.org/docs/2.2/new_features_2_2.html [2] http://www.apache.org/dist/httpd/Announcement2.0.html --=-WtyM75N87g73SYtmghG3 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQBHov02lcRvFfyds/cRAuZzAKCPRpfDMasxV/LW3r7f2/1FQ6njbwCgjNjA XsHbbQ0Bq4pchrGebqRZkLc= =LbPj -----END PGP SIGNATURE----- --=-WtyM75N87g73SYtmghG3--