From owner-freebsd-fs@FreeBSD.ORG Sun Jun 13 00:42:49 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A01A5106564A for ; Sun, 13 Jun 2010 00:42:49 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-jnhn.mail.uoguelph.ca (esa-jnhn.mail.uoguelph.ca [131.104.91.44]) by mx1.freebsd.org (Postfix) with ESMTP id 54BB38FC0A for ; Sun, 13 Jun 2010 00:42:48 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEADfGE0yDaFvG/2dsb2JhbACefnG9M4UaBA X-IronPort-AV: E=Sophos;i="4.53,409,1272859200"; d="scan'208";a="79746927" Received: from amazon.cs.uoguelph.ca ([131.104.91.198]) by esa-jnhn-pri.mail.uoguelph.ca with ESMTP; 12 Jun 2010 20:42:45 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by amazon.cs.uoguelph.ca (Postfix) with ESMTP id 70DEE210156; Sat, 12 Jun 2010 20:42:47 -0400 (EDT) X-Virus-Scanned: amavisd-new at amazon.cs.uoguelph.ca Received: from amazon.cs.uoguelph.ca ([127.0.0.1]) by localhost (amazon.cs.uoguelph.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UXkJO28OFyZZ; Sat, 12 Jun 2010 20:42:46 -0400 (EDT) Received: from muncher.cs.uoguelph.ca (muncher.cs.uoguelph.ca [131.104.91.102]) by amazon.cs.uoguelph.ca (Postfix) with ESMTP id A717B210119; Sat, 12 Jun 2010 20:42:46 -0400 (EDT) Received: from localhost (rmacklem@localhost) by muncher.cs.uoguelph.ca (8.11.7p3+Sun/8.11.6) with ESMTP id o5D0x2g12507; Sat, 12 Jun 2010 20:59:02 -0400 (EDT) X-Authentication-Warning: muncher.cs.uoguelph.ca: rmacklem owned process doing -bs Date: Sat, 12 Jun 2010 20:59:02 -0400 (EDT) From: Rick Macklem X-X-Sender: rmacklem@muncher.cs.uoguelph.ca To: Andrey Simonenko In-Reply-To: <20100611103803.GA1855@pm513-1.comsys.ntu-kpi.kiev.ua> Message-ID: References: <20100611103803.GA1855@pm513-1.comsys.ntu-kpi.kiev.ua> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-fs@freebsd.org Subject: Re: Testers: NFSv3 support for pxeboot for nfs diskless root X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jun 2010 00:42:49 -0000 On Fri, 11 Jun 2010, Andrey Simonenko wrote: > On Wed, Jun 09, 2010 at 07:38:24PM -0400, Rick Macklem wrote: >> I put 3 patches (you need to apply them all) here: >> http://people.freebsd.org/~rmacklem/nfsdiskless-patches/ >> >> They convert lib/libstand/nfs.c and pxeboot to use NFSv3 instead >> of NFSv2 (unless built with OLD_NFSV2 defined). Initial test >> reports have been good. (one has it working ok and the other has >> a problem in an area not related to the patches, it appears) >> >> So, if others are interested in testing these, it would be >> appreciated, rick > > Shouldn't return values from malloc() calls be checked? > Also additional checks for NULL values before free() calls can be removed, > at least this will reduce size of code. There is PR/83424 related to this. > I have updated the patch with these changes. Thanks, rick