From owner-freebsd-hackers@FreeBSD.ORG Tue Mar 4 11:49:59 2008 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 87AB11065677 for ; Tue, 4 Mar 2008 11:49:59 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.freebsd.org (Postfix) with ESMTP id E1A3C8FC24 for ; Tue, 4 Mar 2008 11:49:58 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from kobe.laptop (vader.bytemobile-rio.ondsl.gr [83.235.57.37]) (authenticated bits=0) by igloo.linux.gr (8.14.1/8.14.1/Debian-9) with ESMTP id m24Bng18015359; Tue, 4 Mar 2008 13:49:52 +0200 Received: by kobe.laptop (Postfix, from userid 1000) id B698922802; Tue, 4 Mar 2008 13:49:34 +0200 (EET) Resent-From: keramida@ceid.upatras.gr Resent-Date: Tue, 4 Mar 2008 13:49:34 +0200 Resent-Message-ID: <20080304114934.GA1983@kobe.laptop> Resent-To: "Daniel O'Connor" , freebsd-hackers@freebsd.org Date: Tue, 4 Mar 2008 10:17:30 +0200 From: Giorgos Keramidas To: "Daniel O'Connor" Message-ID: <20080304081730.GA90914@kobe.laptop> References: <20080303.224256.635730757.imp@bsdimp.com> <200803041701.36466.doconnor@gsoft.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200803041701.36466.doconnor@gsoft.com.au> X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-3.973, required 5, autolearn=not spam, ALL_TRUSTED -1.80, AWL 0.43, BAYES_00 -2.60) X-Hellug-MailScanner-From: keramida@ceid.upatras.gr X-Spam-Status: No Cc: freebsd-hackers@freebsd.org, hackers@freebsd.org Subject: Re: Comments on pmake diffs for building on Linux X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Mar 2008 11:49:59 -0000 On 2008-03-04 17:01, Daniel O'Connor wrote: > On Tue, 4 Mar 2008, M. Warner Losh wrote: > > Greetings, > > > > here's a set of diffs that will allow FreeBSD's usr.bin/make to build > > on Linux. I'm sure they are gross, and I don't plan to commit them > > (at least not all of them), but I thought I'd post them here to see > > what people think. > > > > I think that the extra config.h includes, the errc -> errx patches > > and the Makefile.dist patches may be good for the tree. The rest may > > not meet FreeBSD's source tree policies. > > > > Comments? > > I did this a while ago when porting some of our code to Linux because it > builds with pmake.. > > Your patches are much nicer than mine however :) > > The tailq stuff could be shoved into a linux.h or some such.. So it's > more obvious what it's for and why it's there. Solaris lacks TAILQ_xxx stuff too, so I would prefer something like "bsdcompat.h" or similar.