From owner-svn-src-stable@freebsd.org Sat May 12 00:31:42 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C1880FD73E4; Sat, 12 May 2018 00:31:42 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2928780DD1; Sat, 12 May 2018 00:31:41 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w4C0VZwo077989; Fri, 11 May 2018 17:31:35 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w4C0VZ8X077988; Fri, 11 May 2018 17:31:35 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201805120031.w4C0VZ8X077988@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r333503 - stable/11/sys/net In-Reply-To: <20180512100335.B1840@besplex.bde.org> To: Bruce Evans Date: Fri, 11 May 2018 17:31:35 -0700 (PDT) CC: Ian Lepore , "Jonathan T. Looney" , Stephen Hurd , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UNKNOWN-8BIT X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 May 2018 00:31:42 -0000 > On Fri, 11 May 2018, Ian Lepore wrote: > > > On Fri, 2018-05-11 at 19:31 -0400, Jonathan T. Looney wrote: > >> On Fri, May 11, 2018 at 4:40 PM, Stephen Hurd wrote: > >>> > >>> > >>> Author: shurd > >>> Date: Fri May 11 20:40:26 2018 > >>> New Revision: 333503 > >>> URL: https://svnweb.freebsd.org/changeset/base/333503 > >>> > >>> Log: > >>>   MFC r333329, r333366, r333373 > >>> > >>>   r333329: Fix off-by-one error requesting tx interrupt > >>>   r333366: Cleanup queues when iflib_device_register fails > >>>   r333373: Log iflib_tx_structures_setup failure in function > >>> > >> Is this an acceptable style for MFC logs? > >> > >> I'm asking because I actually prefer this to reading (or compiling) the > >> concatenated log messages from several changes. However, I never knew it > >> was acceptable to summarize like this. If it is, I'd like to know so I can > >> adopt it for run-of-the-mill MFCs. > >> > >> Jonathan > > > > This used to be my preferred format, essentially to summarize what's > > being mfc'd. But then I started using the MFC Tracker tool [*] and it > > automatically generates a commit message that contains the full text, > > so I stopped trying to summarize things. > > > > [*] https://mfc.kernelnomicon.org/6/ > > It was the normal style with cvs (to avoid spamming the repository as > well as readers). Howver, one of many worse behaviours in svn is that > after checking out a branch, svn log only shows history for the branch, > so it is hard to find the full log messages even if you know that the > visible ones are only summaries. Though I don't care much for this behavior either you can get the original log entry if you get the changeset number by doing a svn log -c XXXXXX ^/head without that trailing ^/head you get a null output as that change does not exist on your current branch. You can also find the changeset number if the stable/X commit log does not have it by looking at the tail of a svn diff -c XXXXXX which has the mergeinfo in it, if it was done correctly. For this commit it would be svn diff -c 333503 | tail > Bruce -- Rod Grimes rgrimes@freebsd.org