xESRhGz Yaix+Vd7eCNChGQzKMQLBHMRyDK8ZIyR3UL9tGuS6F/Y5uGXqgKl83W0F5DKgEf5FgMaa2 VQWV8tCRJQLlNw0vtby9MECOuQCAd9jmJVmADW/rLx6DmpSGRY2W2A0UagnpVCc62qzO+w MaTTjt59EXTbIgu/RVu6iHJXKNIBLl/P3vsaYYLAtrfrtc+j74O4IPW5V6Y/8eUvAfrHZT fZQFmvlSGDNe5xrbZN0a3Vm9YzD4ndKvhv7T46XyPWwNKqjeCt9kZlvDc6NSjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753191382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KppG/J/YJXaAmt49Xs/f/pkguUlatA3vI/DIl/JR3CI=; b=bnuhiVmrtsycc789TQgOPWhafVO3YS5HmuS2kBVIcqpf6KLF7ah4zH7Eo73oGdk+uYOvPF tCXuQSSs00hPEBTTKEZsyf6yXB4IVVLbu8MIWWPYBxpwiVKgpaSnMw/6Nd0yH0+r1+Q92o W8jGK6fm+Jl/0t27X5ntsUmr6PDDbCdWWqIbDQjax2v6CQ28ltBDZgP2xssrsEovi985Zj 3k/OO/lHwyOS4KODb0WQTplsiFuCnssWVPhuSNNBP6BN8YmfVDIQWVSUa1XKYOUk6RSeLl E2vV9SkWYWKmGWYXD5rF+xLV+RZpGse3FGyXOOV+dnIJ+wJZt60AhFyssIiVBQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1753191382; a=rsa-sha256; cv=none; b=rcmAHXnY9cYwaGJEer8f3YxfQLf1YDH0dnvfIdSeUAT44km+ZF8/sui08Aqkj2sXSykJAY Rknz4VIQeLFTPFuVRI82aUQMjfm+wXX8zvTG2AmDQ6xB065sirKu6Q5hJywDWA0EtqaZfz q1DAISLaxXFsRtBYG3gtpXVxtSfT/FuKfvIFX2J2Eqgk1qZbAyJaYL10Yj08ABl0K9w+wA 3m37Im2Y4Le+0FsqLn7TL+J/GMJM8/KqZUPufrJGM+NgDYeM2UubIlAQYdevheYhb7C5yK ZqwBMFpz1V4aoEUTV3/79pUor9x1fY2Xfbng3OO2KBybyiqH0JB0l1PY3yoimg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bmdZs72xFzTWs; Tue, 22 Jul 2025 13:36:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56MDaLna015196; Tue, 22 Jul 2025 13:36:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56MDaLpL015193; Tue, 22 Jul 2025 13:36:21 GMT (envelope-from git) Date: Tue, 22 Jul 2025 13:36:21 GMT Message-Id: <202507221336.56MDaLpL015193@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: a94dd3955a9f - stable/14 - bsdinstall: wlanconfig: properly format regdomain dialog input List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: a94dd3955a9f7ae51da152c31a4565c1a040c83c Auto-Submitted: auto-generated The branch stable/14 has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=a94dd3955a9f7ae51da152c31a4565c1a040c83c commit a94dd3955a9f7ae51da152c31a4565c1a040c83c Author: Bjoern A. Zeeb AuthorDate: 2025-07-14 18:32:53 +0000 Commit: Bjoern A. Zeeb CommitDate: 2025-07-22 08:21:46 +0000 bsdinstall: wlanconfig: properly format regdomain dialog input Without the extra '\n' the dual-column ('REGD' '') are not properly separated for dialog which leads to an [misleading] error hidden on the command line: Error: --menu bad arguments items number. [Writing this I wonder why the dual-column input is needed]. It is still unclear as to where the error message quoted in PR287538 suddenly came from for 14.3-RELEASE given the code was broken since 2016 (or noone ever noticed or reported). Looking at manual ifconfig output: ifconfig wlan0 country GB regdomain Expected -> ifconfig: unknown regdomain Expected and "ifconfig: " gets stripped by the script, which means the regdomain variable would have to be set to "Expected" or more likely to "Expected eval: Use: not found" which looks like a concatination of errors. Sponsored by: The FreeBSD Foundation Fixes: 95ee591e83a91 PR: 287538 Reviewed by: emaste, thj Differential Revision: https://reviews.freebsd.org/D51313 (cherry picked from commit 5a1e2927d63ed6394b767088eb2d66676f275467) --- usr.sbin/bsdinstall/scripts/wlanconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/bsdinstall/scripts/wlanconfig b/usr.sbin/bsdinstall/scripts/wlanconfig index 728833f8d4a0..6f44ce1b8410 100755 --- a/usr.sbin/bsdinstall/scripts/wlanconfig +++ b/usr.sbin/bsdinstall/scripts/wlanconfig @@ -92,7 +92,7 @@ dialog_country_select() sub(/.*domains:/, ""), /[^[:alnum:][[:space:]]/ { n = split($0, domains) for (i = 1; i <= n; i++) - printf "'\''%s'\'' '\'\''", domains[i] + printf "'\''%s'\'' '\'\''\n", domains[i] } ' | sort ) countries=$( echo "$input" | awk '