From owner-freebsd-current@freebsd.org Fri Jun 8 15:40:46 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BB912101DFBB for ; Fri, 8 Jun 2018 15:40:46 +0000 (UTC) (envelope-from jonlooney@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 4AE5687E68 for ; Fri, 8 Jun 2018 15:40:46 +0000 (UTC) (envelope-from jonlooney@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 097D1101DFBA; Fri, 8 Jun 2018 15:40:46 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C12C3101DFB9 for ; Fri, 8 Jun 2018 15:40:45 +0000 (UTC) (envelope-from jonlooney@gmail.com) Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3EB7387E63; Fri, 8 Jun 2018 15:40:45 +0000 (UTC) (envelope-from jonlooney@gmail.com) Received: by mail-wm0-f48.google.com with SMTP id e16-v6so4107016wmd.0; Fri, 08 Jun 2018 08:40:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=9lhnUd40WTIK2Av7hNHrSuAALLx9jKted4xeXTS0Hfc=; b=Ax8IrquehfHH2lUoDJiTq7vmBERu83P+V7tvu3j87KZQNhrP52B2mQvinhy1/kSr9r yBfW7dkaZGXRduOPbS+/1wlR93/8uS0ATBnELeuo3xoLMLUsxBzziEEk0Z7HeukcxWbg 3zbpGn2y8+qCEGcD3MCjNH3rRfKmicT33GVX9Sk5V08XekEhY9yrkAcBMGjU7tuTETjo kGQSeONvgGZTMjNSmP4ZTrM1igGmIzAwdglxunTOaaD4c80HcXy7cLiNpO0QmLK6YqkJ Rqeb/OgXJVe6fcwe17cygRNV8PmTV1m49MFbbJhOpA7ArsWRFOlomCiWC3ws6IB8unhg 7pkg== X-Gm-Message-State: APt69E18PIvY/l1/rcggsZ1t+q/KKCccoaBo7gDSXAH1v4ySBsn5CwDN AyXj1DMAPLGeJry9xFRHyklpChD3 X-Google-Smtp-Source: ADUXVKKlCjZBMJ7WlnNXQY8+TMwPsbIDwZYmZ5NjSyg/KolwQlHAYmoRVdh7vI+/rD2gqNjWq3pUsg== X-Received: by 2002:a50:fa03:: with SMTP id b3-v6mr7661214edq.26.1528472438141; Fri, 08 Jun 2018 08:40:38 -0700 (PDT) Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com. [74.125.82.54]) by smtp.gmail.com with ESMTPSA id w10-v6sm4481056eda.50.2018.06.08.08.40.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Jun 2018 08:40:37 -0700 (PDT) Received: by mail-wm0-f54.google.com with SMTP id r125-v6so4549339wmg.2; Fri, 08 Jun 2018 08:40:37 -0700 (PDT) X-Received: by 2002:a1c:2dd5:: with SMTP id t204-v6mr2041546wmt.94.1528472437413; Fri, 08 Jun 2018 08:40:37 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:adf:98e2:0:0:0:0:0 with HTTP; Fri, 8 Jun 2018 08:40:36 -0700 (PDT) In-Reply-To: References: <20180608133836.GM1389@albert.catwhisker.org> From: "Jonathan T. Looney" Date: Fri, 8 Jun 2018 11:40:37 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Panic from ipfw_alloc_rule() after r334769 -> r334832 To: David Wolfskill , FreeBSD Current , Mateusz Guzik Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jun 2018 15:40:47 -0000 On Fri, Jun 8, 2018 at 10:52 AM, Jonathan T. Looney wrote: > > On Fri, Jun 8, 2018 at 9:38 AM, David Wolfskill wrote: > > > > Sorry for lack of much analysis; am at BSDCan. jtl@ suggested that a > > sequence of changes involving memory allocation and ipfw counters is > > likely to be at issue. > > Just to be clear, I speculated that this seemed like it could be caused by r334824. > > And, screen_1.jpg does indeed seem to point at that commit. Yes, it is clear that this is hitting r334824. V_ipfw_cntr_zone is defined with UMA_ZONE_PCPU. ipfw_alloc_rule() allocates from V_ipfw_cntr_zone with M_ZERO. That clearly violates the assertion added in r334824, as well as the assumption behind the commit: "Nothing in the tree uses it..." It seems like something will need to be changed here to resolve the mismatch in assumptions/expectations... :-/ If anyone is hitting this bug and needs to get a working system in the meantime, you'll need to revert the following commits which implemented (or updated) this change: r334830 r334829 r334824 Jonathan