From owner-cvs-src@FreeBSD.ORG Thu May 20 06:36:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 12F3616A4CF; Thu, 20 May 2004 06:36:50 -0700 (PDT) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E9F443D4C; Thu, 20 May 2004 06:36:46 -0700 (PDT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.12.9p2/8.12.9) with ESMTP id i4KDac3F096349; Thu, 20 May 2004 17:36:38 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.12.9p2/8.12.9/Submit) id i4KDac2h096348; Thu, 20 May 2004 17:36:38 +0400 (MSD) (envelope-from yar) Date: Thu, 20 May 2004 17:36:37 +0400 From: Yar Tikhiy To: Ruslan Ermilov Message-ID: <20040520133637.GB95319@comp.chem.msu.su> References: <200405201057.i4KAvXHX069548@repoman.freebsd.org> <20040520130439.GH1664@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040520130439.GH1664@ip.net.ua> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 May 2004 13:36:50 -0000 On Thu, May 20, 2004 at 04:04:39PM +0300, Ruslan Ermilov wrote: > On Thu, May 20, 2004 at 03:57:33AM -0700, Yar Tikhiy wrote: > > yar 2004/05/20 03:57:33 PDT > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/em if_em.c > > Log: > > Set the VLAN bits in if_capenable as well as in if_capabilities > > because VLAN hardware features are enabled in em(4) by default. > > > > Note: Currently vlan(4) has a bug that it consults > > if_capabilities, not if_capenable. This will be fixed > > after all the network drivers set VLAN bits in > > if_capenable properly. > > > > Revision Changes Path > > 1.40 +1 -0 src/sys/dev/em/if_em.c > > > Yes, I also noticed this glitch. It would be really nice if > this gets fixed at some point. Are you going to do this? ;) Certainly. But prior to fixing vlan(4) itself I must make sure all the relevant network drivers behave properly, which may take a while since some of them have a maintainer ;-) -- Yar