From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Nov 20 12:30:36 2005 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9025316A41F for ; Sun, 20 Nov 2005 12:30:36 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 957CE43D4C for ; Sun, 20 Nov 2005 12:30:35 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id jAKCUZv4098343 for ; Sun, 20 Nov 2005 12:30:35 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id jAKCUZDx098328; Sun, 20 Nov 2005 12:30:35 GMT (envelope-from gnats) Resent-Date: Sun, 20 Nov 2005 12:30:35 GMT Resent-Message-Id: <200511201230.jAKCUZDx098328@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mark Knight Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D5AF16A41F for ; Sun, 20 Nov 2005 12:21:38 +0000 (GMT) (envelope-from markk@knigma.org) Received: from shrewd.pub.knigma.org (shrewd.pub.knigma.org [81.2.102.154]) by mx1.FreeBSD.org (Postfix) with ESMTP id CB01B43D46 for ; Sun, 20 Nov 2005 12:21:36 +0000 (GMT) (envelope-from markk@knigma.org) Received: from shrewd.pub.knigma.org (localhost [127.0.0.1]) by shrewd.pub.knigma.org (8.13.4/8.13.4) with ESMTP id jAKCLU1F029773 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 20 Nov 2005 12:21:30 GMT (envelope-from mkn@shrewd.pub.knigma.org) Received: (from mkn@localhost) by shrewd.pub.knigma.org (8.13.4/8.13.4/Submit) id jAKCLUe7029772; Sun, 20 Nov 2005 12:21:30 GMT (envelope-from mkn) Message-Id: <200511201221.jAKCLUe7029772@shrewd.pub.knigma.org> Date: Sun, 20 Nov 2005 12:21:30 GMT From: Mark Knight To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/89312: Patch fixes to bugs in net/mtr X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Mark Knight List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Nov 2005 12:30:36 -0000 >Number: 89312 >Category: ports >Synopsis: Patch fixes to bugs in net/mtr >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Nov 20 12:30:34 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Mark Knight >Release: FreeBSD 6.0-STABLE i386 >Organization: >Environment: System: FreeBSD shrewd.pub.knigma.org 6.0-STABLE FreeBSD 6.0-STABLE #0: Wed Nov 16 08:03:51 GMT 2005 root@shrewd.pub.knigma.org:/usr/src/sys/i386/compile/SHREWD i386 >Description: Since upgrading to mtr-0.69, I've been getting duplicate entries for multi-path routers. This first bug affects 5.4 and 6.0: There's also a bug in the IPv6 handling that affects FreeBSD 6.0 (fix found by Hajimu UMEMOTO). >How-To-Repeat: Use mtr on a 6.0-STABLE system. >Fix: The following patch fixes both of these issues: Index: patch-net.c =================================================================== RCS file: /home/ncvs/ports/net/mtr/files/patch-net.c,v retrieving revision 1.1 diff -u -r1.1 patch-net.c --- patch-net.c 29 Oct 2004 22:31:02 -0000 1.1 +++ patch-net.c 16 Nov 2005 19:43:15 -0000 @@ -1,10 +1,28 @@ ---- net.c.orig Wed Aug 25 09:21:27 2004 -+++ net.c Tue Oct 26 12:46:58 2004 -@@ -249,7 +249,6 @@ +--- net.c.orig Thu Jan 13 08:13:53 2005 ++++ net.c Wed Nov 16 19:43:05 2005 +@@ -277,7 +277,7 @@ + exit( EXIT_FAILURE); + } + echotype = ICMP6_ECHO_REQUEST; +- salen = sizeof (struct sockaddr_storage); ++ salen = sizeof (struct sockaddr_in6); + break; + #endif + } +@@ -305,7 +305,6 @@ rv = sendto(sendsock, packet, abs(packetsize), 0, - (struct sockaddr *)&remoteaddress, sizeof(remoteaddress)); + remotesockaddr, salen); if (rv >= 0) { - fprintf (stderr, "You've got a broken (FreeBSD?) system\n"); BSDfix = 1; } } +@@ -346,7 +345,7 @@ + addrcpy( (void *) &(host[index].addrs[0]), addr, af ); + } else { + for( i=0; i >Release-Note: >Audit-Trail: >Unformatted: