From owner-freebsd-net@FreeBSD.ORG Sat Jul 14 21:26:00 2007 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EDE5516A403 for ; Sat, 14 Jul 2007 21:26:00 +0000 (UTC) (envelope-from brian@Awfulhak.org) Received: from storm.uk.FreeBSD.org (storm.uk.FreeBSD.org [194.242.157.42]) by mx1.freebsd.org (Postfix) with ESMTP id 8B04D13C4D0 for ; Sat, 14 Jul 2007 21:26:00 +0000 (UTC) (envelope-from brian@Awfulhak.org) Received: from store.lan.Awfulhak.org (store.lan.Awfulhak.org [172.16.0.35]) by storm.uk.FreeBSD.org (8.14.1/8.14.1) with ESMTP id l6ELPwPr022919; Sat, 14 Jul 2007 22:25:58 +0100 (BST) (envelope-from brian@Awfulhak.org) Received: from store.lan.Awfulhak.org (localhost.localdomain [127.0.0.1]) by localhost (Email Security Appliance) with SMTP id E44AE1957C74; Sat, 14 Jul 2007 21:26:32 +0000 (GMT) Received: from gw.Awfulhak.org (gw.lan.Awfulhak.org [172.16.0.1]) by store.lan.Awfulhak.org (Email Security Appliance) with ESMTP id D4C4C1957C56; Sat, 14 Jul 2007 21:26:28 +0000 (GMT) Received: from dev.lan.Awfulhak.org (brian@dev.lan.Awfulhak.org [172.16.0.5]) by gw.Awfulhak.org (8.14.1/8.14.1) with ESMTP id l6ELPqJN017207; Sat, 14 Jul 2007 14:25:53 -0700 (PDT) (envelope-from brian@Awfulhak.org) Date: Sat, 14 Jul 2007 14:25:51 -0700 From: Brian Somers To: Brett Glass Message-ID: <20070714142551.52f9a6b4@dev.lan.Awfulhak.org> In-Reply-To: <200707141901.NAA27366@lariat.net> References: <200707110014.SAA02181@lariat.net> <200707120114.TAA28481@lariat.net> <20070714114132.6b395616@dev.lan.Awfulhak.org> <200707141901.NAA27366@lariat.net> X-Mailer: Claws Mail 2.10.0 (GTK+ 2.10.13; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: freebsd-net@freebsd.org, Mike Tancsa Subject: Re: Bug in userland PPP LQR? X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jul 2007 21:26:01 -0000 On Sat, 14 Jul 2007 13:01:06 -0600 Brett Glass wrote: > At 12:41 PM 7/14/2007, Brian Somers wrote: > >I expect unacknowledged LQR packets to be resent > >5 times (exactly the same packet), and the 6th > >timeout to cause a line drop. > > That's what I thought too. But it seems as if a > single dropped packet among plenty of successful > ones can cause the session to drop. This is > why I am wondering if the counter is properly reset > or if one missed packet leads to a permanent loss > of synchronization. The lqm logging should prove/disprove that ppp is sending the packet 6 times. The code *looks* ok. The counter is reset at line 236 of lqr.c (on receipt of an LQR packet). -- Brian Somers Don't _EVER_ lose your sense of humour !