From owner-freebsd-emulation@FreeBSD.ORG Mon Jul 30 19:40:12 2012 Return-Path: Delivered-To: emulation@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F2D821065672 for ; Mon, 30 Jul 2012 19:40:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C469D8FC15 for ; Mon, 30 Jul 2012 19:40:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q6UJeCxe070187 for ; Mon, 30 Jul 2012 19:40:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q6UJeCvl070186; Mon, 30 Jul 2012 19:40:12 GMT (envelope-from gnats) Date: Mon, 30 Jul 2012 19:40:12 GMT Message-Id: <201207301940.q6UJeCvl070186@freefall.freebsd.org> To: emulation@FreeBSD.org From: Tijl Coosemans Cc: Subject: Re: ports/169702: [patch] graphics/linux-f10-tiff: fix packing list X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Tijl Coosemans List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2012 19:40:13 -0000 The following reply was made to PR ports/169702; it has been noted by GNATS. From: Tijl Coosemans To: Boris Samorodov Cc: bug-followup@FreeBSD.org, freebsd-emulation@FreeBSD.org Subject: Re: ports/169702: [patch] graphics/linux-f10-tiff: fix packing list Date: Mon, 30 Jul 2012 21:35:51 +0200 On 30-07-2012 17:52, Boris Samorodov wrote: > 30.07.2012 17:42, Tijl Coosemans пишет: >> On 30-07-2012 14:18, Boris Samorodov wrote: >>> 30.07.2012 16:00, Tijl Coosemans пишет: >>>> On 30-07-2012 13:39, Boris Samorodov wrote: >>>> > While agree with DESCR part, I'm not sure about PLIST one >>>> > since I can't reproduce it. Can you provide some more >>>> > details? >>>> >>>> I'll take a closer look later, but maybe it's because I have >>>> "WRKDIRPREFIX=/usr/obj" in /etc/make.conf. >>> >>> That imho should not be the case. >> >> It's because of WRKDIRPREFIX in combination with portmaster. >> >>>> Also, in bsd.port.mk >>>> the default value of PLIST is ${PKGDIR}/pkg-plist. >>> >>> This is really more accurate. Seems that this should be >>> done for all ports using a non-standard PLIST. >> >> Yes, here are some others: >> >> # grep -R '^PLIST=' * | grep -v -E '(WRKDIR|CURDIR|PKGDIR|MASTERDIR|FILESDIR|WRKSRC|NONEXISTENT)' >> audio/linux-esound/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH} >> audio/linux-f10-libaudiofile/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH} >> audio/linux-libaudiofile/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH} >> cad/salome/Makefile.ext:PLIST= ../salome${PKGNAMESUFFIX}/pkg-plist >> devel/linux-libglade/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH} >> devel/linux-libglade2/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH} >> games/qix/Makefile:PLIST= pkg-plist.x11 >> graphics/linux-f10-imlib/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH} >> graphics/linux-f10-tiff/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH} >> graphics/linux-imlib/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH} >> graphics/linux-tiff/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH} >> graphics/linux-ungif/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH} >> japanese/namazu2/Makefile:PLIST= "@comment this plist is intentionally left empty" >> security/ossec-hids-client/Makefile:PLIST= pkg-plist.client >> security/sinfp/Makefile:PLIST= "" >> textproc/linux-libxml/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH} >> textproc/linux-libxml2/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH} >> x11-toolkits/linux-f10-gtk/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH} >> x11-toolkits/linux-f10-qt33/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH} >> x11-toolkits/linux-gtk/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH} >> x11-toolkits/linux-qt33/Makefile:PLIST= pkg-plist.${LINUX_RPM_ARCH} >> > > OK, as of linux ports. Here is a patch. Any objections? Looks good to me.