From owner-freebsd-current@FreeBSD.ORG  Wed Jul  4 15:44:03 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@FreeBSD.org
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 4809116A400;
	Wed,  4 Jul 2007 15:44:03 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69])
	by mx1.freebsd.org (Postfix) with ESMTP id A3E0713C455;
	Wed,  4 Jul 2007 15:44:02 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l64Fi0HW032356;
	Wed, 4 Jul 2007 19:44:00 +0400 (MSD)
	(envelope-from ache@nagual.pp.ru)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nagual.pp.ru;
	s=default; t=1183563841; bh=wlahEGC3ZnHyBgaryR5H7FA1Ig7XitGyKb7ZUM/
	f0EA=; l=293; h=Received:Date:From:To:Cc:Subject:Message-ID:
	Mail-Followup-To:References:MIME-Version:Content-Type:
	Content-Disposition:In-Reply-To:User-Agent; b=HdboNQXG6JIvCw6tiSci
	PUexYd6FobSWv+dPrODiGsewm1BHnxA2goQIpBDgeVov9OzBS7+VgxLtVPA7u8BlTdN
	yEvmFqRDvIVGy1U2wejLAdHs85uO/ANJGrfFLV9tn1nxnLG394hVRR3gZunb9WHmtRo
	gyy5MwM2Amda/lR2M=
Received: (from ache@localhost)
	by nagual.pp.ru (8.14.1/8.14.1/Submit) id l64Fi03H032355;
	Wed, 4 Jul 2007 19:44:00 +0400 (MSD) (envelope-from ache)
Date: Wed, 4 Jul 2007 19:44:00 +0400
From: Andrey Chernov <ache@nagual.pp.ru>
To: "Sean C. Farley" <scf@FreeBSD.org>
Message-ID: <20070704154400.GA32318@nagual.pp.ru>
Mail-Followup-To: Andrey Chernov <ache@nagual.pp.ru>,
	"Sean C. Farley" <scf@FreeBSD.org>,
	freebsd-current <freebsd-current@FreeBSD.org>,
	Michal Mertl <mime@traveller.cz>
References: <1183557221.1799.16.camel@genius.i.cz>
	<20070704143642.GA31254@nagual.pp.ru>
	<20070704150312.GB31683@nagual.pp.ru>
	<20070704101026.O77978@thor.farley.org>
	<20070704152310.GA31964@nagual.pp.ru>
	<20070704103822.H77978@thor.farley.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070704103822.H77978@thor.farley.org>
User-Agent: Mutt/1.5.16 (2007-06-09)
Cc: freebsd-current <freebsd-current@FreeBSD.org>,
	Michal Mertl <mime@traveller.cz>
Subject: Re: Environment handling broken in /bin/sh with changes to
	{get,set,put}env()
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jul 2007 15:44:03 -0000

On Wed, Jul 04, 2007 at 10:38:50AM -0500, Sean C. Farley wrote:
>> IMHO it should be changed to
>> 
>> 	if (set && eqp != NULL)
>> 
>> i.e. go to unsetenv() for values without "="
> 
> Good point.  I updated the patch.

Ok. Then, send it to re@ for approvement.

-- 
http://ache.pp.ru/