From owner-svn-src-head@freebsd.org Wed Feb 6 17:29:52 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 30EB814D9E85 for ; Wed, 6 Feb 2019 17:29:52 +0000 (UTC) (envelope-from will@firepipe.net) Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5D77776187 for ; Wed, 6 Feb 2019 17:29:51 +0000 (UTC) (envelope-from will@firepipe.net) Received: by mail-qk1-x72f.google.com with SMTP id m9so4756148qkl.4 for ; Wed, 06 Feb 2019 09:29:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=firepipe-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lDbqXr/eoSBPwNgBJa2f/so2vV4juU3i2pRhuUU2IaM=; b=d3ktz26SsTPVXAT7rVER1W8CwP/vwojaiDtx+haeB0V5bcwit8+Sbc+pY6AZ5JGJeb zw1rce6TldunPiIK5Y8lVsGsKuLfXfHPB+LDFgQCsCzt3JN2Nk/eWpPQTEZEDvrEcqgo esuX2Rh6YZhzzcmd8vvhKNhl6MbsaJ8arfpg4HFG1BrGuybqJFFPXW9yeJ4rfXC/ynFp kGpkpy70VNKpXakyCRPf+rhojBnKGXI13DlQeomgGV0AQ8UW6TXkrRYf5+NoP9yaDqHT 6qu1sOtbqwZq2pEB/Y+93xKFf4sOBVdU58b6SLz/8AUmvj6vJo4vt2k3tLeqiw1j1ElV N3aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lDbqXr/eoSBPwNgBJa2f/so2vV4juU3i2pRhuUU2IaM=; b=tlDg/DMsYuG8/lRBfGmY4v8iLy8R5Hm8YAnapklkOLCEKbDUU7HCclEEEhN7IhqQZa pZX11Cd6gnAGTB9clD8z6Pk+vGCaSUHDxqNFV7Jfr8s6+B9kd/PX0HnUDNcQgEsO0fBY pSYhhQLnmAkfCCAWTj1SFHeOE2QIQj260JooGcY6nCrMaLJfi/8S7rJsFFbgmlmbNHAD 8QuQWvrNFTIakIVscCHUG0FMtTfkqQ2ErXjthzShTyaqhsxJhyCYYYuOX01VVtXHGZnX bKUUOFEd7n6bM8r+imt1DsLgw0whum7ySCt6nKtn2GfVwAi8XReTism8cCHqrEqyhvPu qunA== X-Gm-Message-State: AHQUAua/bMI4HcSYcbfps79i4+6kRydJJm6ExPZtm89eO8wHTKWK1tyF nvJTrx4cz/7CpuT0P5F+0xchiCdWlM/6pAteoZNhXQ== X-Google-Smtp-Source: AHgI3IZPDIb7JMiW080JquuFQICFnq8r2QIQ98tVGCUmIqjwqUk7qdE65Bal2o1gZz+tbwAJWgDPHuEvMZwGAHX7Gu0= X-Received: by 2002:a37:de19:: with SMTP id h25mr8519442qkj.146.1549474187722; Wed, 06 Feb 2019 09:29:47 -0800 (PST) MIME-Version: 1.0 References: <201711112330.vABNUwXC077395@repo.freebsd.org> <20190205202145.A1080@besplex.bde.org> <20190206024025.X3175@besplex.bde.org> In-Reply-To: <20190206024025.X3175@besplex.bde.org> From: Will Andrews Date: Wed, 6 Feb 2019 11:29:32 -0600 Message-ID: Subject: Re: svn commit: r325728 - head/lib/libkvm To: Bruce Evans Cc: Ed Maste , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 5D77776187 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=firepipe-net.20150623.gappssmtp.com header.s=20150623 header.b=d3ktz26S X-Spamd-Result: default: False [-6.03 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[firepipe-net.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[firepipe.net]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[firepipe-net.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[cached: aspmx.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[f.2.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.93)[-0.928,0]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[optusnet.com.au]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; IP_SCORE(-2.79)[ip: (-9.41), ipnet: 2607:f8b0::/32(-2.50), asn: 15169(-1.96), country: US(-0.07)] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2019 17:29:52 -0000 On Tue, Feb 5, 2019 at 10:25 AM Bruce Evans wrote: > Signed kp_offset seems wrong. Apart from it not reaching the top of 64- > bit address spaces, adding unsigned kp_len to it gives an unsigned type. > It's appropriate, because in this context, we return page information including addresses that would be valid pointer references, but are not included in the core file. Minidumps omit large numbers of physical pages, so calls to kvm_walk_pages() will generate large numbers of kvm_page instances that have an offset of -1. --Will.