From owner-freebsd-threads@FreeBSD.ORG  Sat Feb 19 13:34:11 2005
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id ECD2F16A4CE; Sat, 19 Feb 2005 13:34:11 +0000 (GMT)
Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id B8C1143D2D; Sat, 19 Feb 2005 13:34:11 +0000 (GMT)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by cyrus.watson.org (Postfix) with SMTP id 520F946B8E;
	Sat, 19 Feb 2005 08:34:11 -0500 (EST)
Date: Sat, 19 Feb 2005 13:32:41 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-Sender: robert@fledge.watson.org
To: Craig Rodrigues <rodrigc@crodrigues.org>
In-Reply-To: <20050218211808.GA12700@crodrigues.org>
Message-ID: <Pine.NEB.3.96L.1050219133200.67347V-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: tmclaugh@sdf.lonestar.org
cc: freebsd-gnats-submit@freebsd.org
cc: freebsd-threads@freebsd.org
Subject: Re: threads/76938: include/unistd.h: ttyname_r prototype missing
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 19 Feb 2005 13:34:12 -0000


On Fri, 18 Feb 2005, Craig Rodrigues wrote:

> On Fri, Feb 18, 2005 at 03:51:01PM -0500, Daniel Eischen wrote:
> > Style: all returns should be "return (foo)", not "return foo".
> 
> OK, the attached patch fixes this.
> 
> > This may also cause an ABI change since ttyname_r use to
> > return (char *).  I'm not sure of the impact though 'cause
> > it was never in a header file.
> 
> This does change the ABI, but I also don't know what the impact is,
> since this function was not exported from a header file. 
> 
> The old ttyname_r() should have been declared static, since it was never
> exported through a header file, but that's life.  At least the new
> ttyname_r() conforms to SuS, so it has a better chance of working with
> software written on other platforms. 

You might want to ask Kris Kenneway if he could do a scan of the
ports/packages to see what links against the ttyname_r symbol, if
anything.

Robert N M Watson