From owner-svn-src-all@FreeBSD.ORG Mon Nov 15 15:00:20 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6E48C106564A; Mon, 15 Nov 2010 15:00:20 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [IPv6:2001:4068:10::3]) by mx1.freebsd.org (Postfix) with ESMTP id 56DBE8FC0C; Mon, 15 Nov 2010 15:00:08 +0000 (UTC) Received: from localhost (amavis.fra.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 530C641C736; Mon, 15 Nov 2010 16:00:07 +0100 (CET) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([192.168.74.103]) by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id oYW82thhsoXB; Mon, 15 Nov 2010 16:00:06 +0100 (CET) Received: by mail.cksoft.de (Postfix, from userid 66) id A9E4041C735; Mon, 15 Nov 2010 16:00:06 +0100 (CET) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 729234448F3; Mon, 15 Nov 2010 14:58:15 +0000 (UTC) Date: Mon, 15 Nov 2010 14:58:15 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Dimitry Andric In-Reply-To: <201011142040.oAEKetST093270@svn.freebsd.org> Message-ID: <20101115145153.C24596@maildrop.int.zabbadoz.net> References: <201011142040.oAEKetST093270@svn.freebsd.org> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r215318 - in head/sys: net sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Nov 2010 15:00:20 -0000 On Sun, 14 Nov 2010, Dimitry Andric wrote: > Author: dim > Date: Sun Nov 14 20:40:55 2010 > New Revision: 215318 > URL: http://svn.freebsd.org/changeset/base/215318 > > Log: > Instead of unconditionally emitting .globl's for the __start_set_xxx and > __stop_set_xxx symbols, only emit them when the set_vnet or set_pcpu > sections are actually defined. Unless you have a very good reason that is NOT cosmetic for this I want to know it. None of you commit messages is giving this. This breaks the classic C semantics that we had gained with the former type of macros, which is a shame. Kind of annoying neither of the changes had a Reviewed by: and despite being about 2 weeks behind of most email I hadn't spotted this on arch@ before nor seen it on virtualization@ that it obviously touches. I would have loved to hear about them before foing to have a hard time integrating this white space into half a year of development work. Looking forward to the technical explanation. > Modified: > head/sys/net/vnet.h > head/sys/sys/cdefs.h > head/sys/sys/linker_set.h > head/sys/sys/pcpu.h -- Bjoern A. Zeeb Welcome a new stage of life. Going to jail sucks -- All my daemons like it! http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/jails.html