From owner-freebsd-current@FreeBSD.ORG Tue May 22 11:04:20 2007 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D4FA316A41F for ; Tue, 22 May 2007 11:04:20 +0000 (UTC) (envelope-from bkoenig@cs.tu-berlin.de) Received: from mail.liberty-hosting.de (mail.smartterra.de [195.225.132.203]) by mx1.freebsd.org (Postfix) with ESMTP id 9515F13C45D for ; Tue, 22 May 2007 11:04:20 +0000 (UTC) (envelope-from bkoenig@cs.tu-berlin.de) Received: from mail.liberty-hosting.de ([195.225.132.203]) by localhost (liberty-mail [195.225.132.203]) (amavisd-new, port 10024) with ESMTP id 46517-01 for ; Tue, 22 May 2007 12:40:30 +0200 (CEST) Received: from home.alpha-tierchen.de (port-212-202-170-5.dynamic.qsc.de [212.202.170.5]) by mail.liberty-hosting.de (Postfix) with ESMTP id E8E2E18112C for ; Tue, 22 May 2007 12:40:29 +0200 (CEST) Received: from webmail.alpha-tierchen.de (localhost [127.0.0.1]) by home.alpha-tierchen.de (Postfix) with ESMTP id C035D45046 for ; Tue, 22 May 2007 12:40:26 +0200 (CEST) Received: from 2001:6f8:101e:0:20e:cff:fe6d:6adb (SquirrelMail authenticated user bkoenig) by webmail.alpha-tierchen.de with HTTP; Tue, 22 May 2007 12:40:26 +0200 (CEST) Message-ID: <63182.2001:6f8:101e:0:20e:cff:fe6d:6adb.1179830426.squirrel@webmail.alpha-tierchen.de> Date: Tue, 22 May 2007 12:40:26 +0200 (CEST) From: =?iso-8859-1?Q?Bj=F6rn_K=F6nig?= To: current@freebsd.org User-Agent: SquirrelMail/1.4.9a MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Virus-Scanned: by amavisd-new at mail.smartterra.de X-Mailman-Approved-At: Tue, 22 May 2007 11:57:00 +0000 Cc: Subject: sysinstall says "BARF", concerns libdisk and geom_label X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2007 11:04:20 -0000 Hello, when I start sysinstall I get the error message "BARF 148 <88>". The reason for this is the label of my Windows partion, it is called "Windows XP" and contains a space character. libdisk/open_disk.c needs to parse the value of kern.geom.conftxt which contains spaces as field seperator, therefore it fails. A quick and dirty workaround would be to skip labels that contain space characters, which can be easily done in g_label_is_name_ok (sys/geom/label/g_label.c). But I am looking for a better solution. So it might be more accurate to revise libdisk, i.e. improve the parsing of kern.geom.conftxt. Maybe the best but most time-consuming solution is to change the output of kern.geom.conftxt to another format, e.g. XML. Are there any comments or other suggestions? Björn