Date: Sun, 5 May 2002 14:34:51 -0700 From: Marcel Moolenaar <marcel@xcllnt.net> To: Peter Wemm <peter@wemm.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 10841 for review Message-ID: <20020505213451.GB754@dhcp01.pn.xcllnt.net> In-Reply-To: <20020505211549.10F2D3811@overcee.wemm.org> References: <20020505210011.GA754@dhcp01.pn.xcllnt.net> <20020505211549.10F2D3811@overcee.wemm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, May 05, 2002 at 02:15:49PM -0700, Peter Wemm wrote: > Marcel Moolenaar wrote: > > On Sun, May 05, 2002 at 01:55:09PM -0700, Marcel Moolenaar wrote: > > > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=10841 > > > > > > Change 10841 by marcel@marcel_vaio on 2002/05/05 13:54:28 > > > > > > Prune the branch: > > > We don't need a dummy __cxa_finalize anymore. We now handle > > > weak references to undefined symbols correctly. > > > > > > Affected files ... > > > > > > ... //depot/projects/ia64/lib/libc/ia64/gen/Makefile.inc#8 edit > > > ... //depot/projects/ia64/lib/libc/ia64/gen/cxa.c#4 delete > > > ... //depot/projects/ia64/sys/ia64/ia64/exception.s#13 edit > > > ... //depot/projects/ia64/sys/ia64/ia64/genassym.c#6 edit > > > ... //depot/projects/ia64/sys/ia64/ia64/machdep.c#36 edit > > > ... //depot/projects/ia64/sys/ia64/include/frame.h#3 edit > > > ... //depot/projects/ia64/sys/ia64/include/reg.h#3 edit > > > > Whoops! This should only have the first 2 files. I'll double check > > that what got piggybacked doesn't revert Peter's work (ie it breaks > > builds)... > > It looked mostly harmless. It was fragments of debugger support, right? Yes. Only genassym.c was bogus. A left-over I should have reverted locally days ago... > BTW: p4 diff -du before commit is your friend. > BTW2: "p4 submit lib/libc/ia64/gen/..." is also your friend. :-) > BTW3: you can edit out the lines in the submit template to not commit > those files. ie: if you had noticed and deleted exception.s etc, it > would have left them behind, still open. Ah, ok, thanks. Especially BTW3 is a good feature. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020505213451.GB754>