From owner-freebsd-current@freebsd.org Thu Jul 9 14:11:30 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E1C629969B1 for ; Thu, 9 Jul 2015 14:11:30 +0000 (UTC) (envelope-from ermal.luci@gmail.com) Received: from mail-yk0-x22d.google.com (mail-yk0-x22d.google.com [IPv6:2607:f8b0:4002:c07::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9B0941650; Thu, 9 Jul 2015 14:11:30 +0000 (UTC) (envelope-from ermal.luci@gmail.com) Received: by ykey15 with SMTP id y15so40707019yke.3; Thu, 09 Jul 2015 07:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=LJf/YRKMBqtghxx+YB03qCEIguPKIC3c4O5QPI3MZKw=; b=iDopKZANmMaQ0AKXlLuMETja0megTkzDuDCEG0/z3aulPxJe75etSI1ZI3J3phrF9z iCpVH/q7uV4LzwUWWVHEAxUXL7uFjawJ2uhcSGnNGrxV+uLDY9ajW3XuE6VJiXuJSH5T c1dpaeWiymQS7tPhw7gv6WLk39AEmyVx+1GCajiSvEdPboN5GErSKRiIovHhlC/yQhac 3lXRiilOkJHUCmniv+4QJP1FycdhFYTyegfElQurNS981HGMwOqwDMlLiEJiVPoLeDE/ 0RAB+5DqwxI5nlhths+ysmbKbJLxO2yluM0F0w6iqiwu3p7f0rUYFDMi4CUGXJNe91w9 48XQ== MIME-Version: 1.0 X-Received: by 10.13.236.5 with SMTP id v5mr17828206ywe.138.1436451089768; Thu, 09 Jul 2015 07:11:29 -0700 (PDT) Sender: ermal.luci@gmail.com Received: by 10.129.83.139 with HTTP; Thu, 9 Jul 2015 07:11:29 -0700 (PDT) In-Reply-To: References: <20150705151541.GC45822@rink.nu> <20150706072154.GA86301@rink.nu> <20150707161107.GE86301@rink.nu> Date: Thu, 9 Jul 2015 16:11:29 +0200 X-Google-Sender-Auth: eGNgrmMskJ29fbTKo2guZ34i1ks Message-ID: Subject: Re: panic: negative refcount after dhclient during boot From: =?UTF-8?Q?Ermal_Lu=C3=A7i?= To: Rink Springer Cc: "freebsd-current@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2015 14:11:31 -0000 On Wed, Jul 8, 2015 at 5:09 PM, Ermal Lu=C3=A7i wrote: > > > On Tue, Jul 7, 2015 at 6:11 PM, Rink Springer wrote: > >> Hi eri@, >> >> On Mon, Jul 06, 2015 at 09:21:54AM +0200, Rink Springer wrote: >> > On Sun, Jul 05, 2015 at 12:45:25PM -0700, Garrett Cooper wrote: >> > > On Jul 5, 2015, at 8:16, Rink Springer wrote: >> > > >> > > > Hi all, >> > > > >> > > > On my FreeBSD/mips machine (it's a RouterStation Pro), I get the >> > > > following panic during boot: >> > > >> > > ? >> > > >> > > > This reproduces 100%. I'm at: >> > > > >> > > > FreeBSD 11.0-CURRENT #0 r285099: Sun Jul 5 12:31:47 CEST 2015 >> > > > >> > > > Let me know what I can do to help track this down; I only started >> > > > getting the panic after 'gateway_enable=3DYES' in /etc/rc.conf >> > > > >> > > > The kernel has INVARIANTS but no WITNESS. Config available at >> > > > http://rink.nu/tmp/FRINGE - boot log at >> http://rink.nu/tmp/fringe.txt >> > > >> > > Please file a bug! >> > >> > Done, 201371. >> >> After a suggestion by adrian@, it seems reverting r285051 fixes the >> problem for me (i.e. the system boots now) >> >> > Can you please try with this patch and let me know if it fixes the issue. > > Index: sys/netinet/ip_output.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/netinet/ip_output.c (revision 285271) > +++ sys/netinet/ip_output.c (working copy) > @@ -660,6 +660,13 @@ > done: > if (ro =3D=3D &iproute) > RO_RTFREE(ro); > + else if (rte =3D=3D NULL) > + /* > + * If the caller supplied a route but somehow the referen= ce > + * to it has been released need to prevent the caller > + * calling RTFREE on it again. > + */ > + ro->ro_rt =3D NULL; > if (have_ia_ref) > ifa_free(&ia->ia_ifa); > return (error); > > >> Regards, >> Rink > > Actually this is the correct fix apparently. https://reviews.freebsd.org/D3036 --=20 Ermal