From nobody Thu May 28 19:26:34 2026 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gRGgt6vZtz6dy5v; Thu, 28 May 2026 19:26:34 +0000 (UTC) (envelope-from osa@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gRGgt4mLwz4D6r; Thu, 28 May 2026 19:26:34 +0000 (UTC) (envelope-from osa@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779996394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZZrRfItf/VUnOl1lM2FLx0J/1TeG4pl83hm+ivKkKSU=; b=ZYVMyZdA2zus13aAXEH1d8FQrPNTn+b4LECxNHPelTZ7bpie78M0OD0gJzXcnab+rV/8tM WN/5RSGLuO1X6YDKjLxzGRuCcQrA7tYbhDCAyO579ifjM3eZYrs71+cIYmWhIoQLZRfMYc +h1UX+8gelHaEVjfeFj55I2U/KTD7Tz9wfd0tT0puDHCo5uSgLP/Y1snwzOAJp7vzm7SLw dkLsHQazF+7hNg6EYeEOtRrozdSszVqrbiZk1pBfbrMn+GaP7N61STUyyB+IqWr1x7+brm dST7LPIAn7ZWnKGlAoxfXrlu6FzZbV0bguifYZ3JIvd6Y+tYJ7p5ezitW162aQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779996394; a=rsa-sha256; cv=none; b=B8c3istfL0dLvgX+zlEbjh4dqwqp0DjBWj8xYd+pYnQmeBL6HsGP+7yXS1cKKPj1HxUr2B Xn7ce3Eskmu4Bp3ZgKAkmXkgFrYbPbOjWAfTM4FqG5YKn1T4Byi/P+KNGOqLifCj2OorJY wRaNi3CZNBbxZHgollPJWB3UREvKmGBn+X9FN9qpiSK4dHNg+3YhBKxtQHZaCgVCrJOg+l WVgi2J0uPdMJ46qKLOf1G2gI21wELblBCMwpdxCbVUel+tcVTmZEkkKCOzvd+YhRBeLCtC jL2GmrZYzMiw7skNHmYUBD6zba58R3KPYK5zYGv4y9jh+OnhWnzbHGWK0nYKQg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779996394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZZrRfItf/VUnOl1lM2FLx0J/1TeG4pl83hm+ivKkKSU=; b=GnxV9un8gaTQEojRZKddmHKNEE7LfP+lcuKrsu6ocqh/1UaGR0oVuwnfut4InkfYY4bS6L 19eMYgxsTlU0pfwf/nlSHGElFMFoqo+efs3A344K1kKsdqDMbr8xDEEVZQF4N/Gw8BBcp7 Tit9+CS82Oc9Yw7He3Eaz7j6KMWPjiuA8+3psESlzQkFcEJEno5o08wP4zlWE/eXUtcly5 nA5kiwn19cL28PQ6AlHKlpuhBrnAOtN5MIYzFJZ5TIRYBO/luHKYYnBEMkHerYTEeiA2oJ DHDQoo0uRMmABq+uT1MSlwdaH2TrIEjKQQF5y2r4M92ehoQlO+SoJHCTEhAYNg== Received: by freefall.freebsd.org (Postfix, from userid 975) id 78BCE129FA; Thu, 28 May 2026 19:26:34 +0000 (UTC) Date: Thu, 28 May 2026 19:26:34 +0000 From: "Sergey A. Osokin" To: Jochen Neumeister Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 89e246c1b719 - main - www/lua-stream-nginx-module: Add new port Message-ID: References: <6a142091.31bc1.776944a4@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Hi Jochen, thanks for the reply. On Wed, May 27, 2026 at 11:16:31PM +0200, Jochen Neumeister wrote: > Hi Sergey, > > the main reason for these ports is to have the related third-party module > dependencies directly available as standalone ports in the FreeBSD Ports > tree instead of only embedding them via GH_TUPLE. I still believe that's the best approach. > This makes it easier to manage upstream releases and required compatibility > adjustments in a more centralized and consistent way. It also helps to keep > updates and compatibility changes synchronized across the different NGINX > ports instead of maintaining the same source handling logic in multiple > places. Different NGINX ports may have different versions, flavors, something else, so support just one port for all of those variants look pretty complex to me. > That said, I absolutely understand your point regarding the currently > installed contents. The initial version was intentionally kept very close to > the upstream source tree to simplify integration and compatibility testing > during the transition from Makefile.extmod handling to standalone ports. > > I do agree that files such as .github metadata, CI files, git-related files, > and probably large parts of the test suite should not be packaged. I will > clean this up over the next days and reduce the installed contents to the > actually required module sources and related build files. Well, tests are definitely don't need to be a part of the final package. However, tests are very useful during build process: right after the build it's great idea to run tests against a fresh build to see the results and measure the quality of the final product. So, tests removal isn't good idea as well. Follow that, it's better to return back to the approach we had with a GH_TUPLE definition for a third-party module in nginx ports. > Am 27.05.26 um 22:09 schrieb Sergey A. Osokin: > > Hi Jochen, > > hope you're doing well. > > > > Could you please provide a reason for this port. > > I do believe that the existing schema with defining sources in > > the Makefile.extmod is good enough to support third-party > > modules. On other side, it's possible to create a port to > > make a binary module. > > > > I'm also curious why do we need to keep github attibutes, tests, > > and other staff as a package. [...] Thank you. -- Sergey A. Osokin