From nobody Thu Jun 13 19:50:01 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4W0Y0V0XHvz5PFPs; Thu, 13 Jun 2024 19:50:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4W0Y0V007rz3wg5; Thu, 13 Jun 2024 19:50:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1718308202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=or+um3x5AjN4YCMtkq/EGET0sCb7LE0WhzsihCeR7Nc=; b=TWnRsTcdHbV2VeiL6xSjT48VSdmBki6uWvWJjzX0kEbpg9uohNvYltPleinXHm+3+X+kGP 8G/+7h7GKsA+QvwJILP/hejRtBe5gvRKDzDUl6yWPBfAICRfkU9UbsRhuHDNafgjo1aSmY 7Tl9jReq2RcRuSwk6SROa7+CRxWKm5zb/ZSKd4HezIw6IbGrBgHmX00hKFcg1JyMv9xCTf b7q4xyLbjuf5qqm8hPuxSm+QX6EsFWSeK+YaIWCcHWv31WtiJz6zZGiwjNNUiDG7UehZCd tVd3XS9tPtK2h37XFvUjYfOQbDcZpCJBGsk7UJPuUNYPru9OTuSWaDxltZl5fA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1718308202; a=rsa-sha256; cv=none; b=OMKK4W6/+ccn2AuUuKPxOT1Y7WSjPweDy4NPfLi3hJv97RDgyaTxPv8aB2vpOpL+Sa26Lj /npV3227pSgYIsaqvbIhA1b9vz1RQduu7FT6THbfCaMGvPOHUMRMb4uKS/1gM0RPdNCoGd o2g7GbJ45ltxDrbxDGNtl99IkLZThWY8vAU5wNdMSOt1gpmm1S65zx1OCrUFdDbQNMtHGQ zcWAAMsOTfkO4LiFaI5UtZRs5BMIQBpfQwrTkyLRXbrXv32WP2ze/qpGymsm0akWCymuPe 2UBYS0v8dIQrmoc92SsJRLxfESfrNziG+v3Sa0midFbBRq8rwFGIdS2rBbYd3g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1718308202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=or+um3x5AjN4YCMtkq/EGET0sCb7LE0WhzsihCeR7Nc=; b=jkCD8jAyCIHaHoiof9Q6CFfg2eS7l2xEyj/IKGiDZdVVzs8FEfkbibTKQF2a0AllHQ+BeL ihy67hI8f87/OSrO9Nr3MB4+JvrvwS7SubMtR4Rr7fVbFJQ67mHMUs8RsN2Eu4uYIq845r VekGpmN47+9OJqDZIIiqk+NSF4FQhQUDbN333JsD4vDF9HswkCpL6aIKRKUguz1DX69XRH 0rwIDp+nNm6SfKv7lwrpHcKL4OtWOC7F3niiZXMdYjJGgVfgMTE+JE/6UeSRRZIqGnTzw2 QuyTROJV8CR1CfGEfIUl3tBq1cn5Up8KmHPPHtZw0PrO0KFNHKXPFJ/clI8ayQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4W0Y0T6hzmzqHR; Thu, 13 Jun 2024 19:50:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 45DJo1VB092185; Thu, 13 Jun 2024 19:50:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 45DJo1vB092180; Thu, 13 Jun 2024 19:50:01 GMT (envelope-from git) Date: Thu, 13 Jun 2024 19:50:01 GMT Message-Id: <202406131950.45DJo1vB092180@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Alan Somers Subject: git: bd11dd6fb9a0 - stable/13 - fusefs: only test for incoherency if FN_SIZECHANGE is set List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: asomers X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: bd11dd6fb9a0e4daa04f0fa66ed38d44f716e919 Auto-Submitted: auto-generated The branch stable/13 has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=bd11dd6fb9a0e4daa04f0fa66ed38d44f716e919 commit bd11dd6fb9a0e4daa04f0fa66ed38d44f716e919 Author: Emil Tsalapatis AuthorDate: 2024-02-08 01:13:43 +0000 Commit: Alan Somers CommitDate: 2024-06-13 19:46:01 +0000 fusefs: only test for incoherency if FN_SIZECHANGE is set FUSE emits spurious incoherency warnings in writethrough mode. The warnings are triggered by setattr calls generated by vnode truncation turning the cached va_size vattr stale, causing comparisons with the fresh version provided by the server to fail. Only validate the vnode's va_size vattr if the FN_SIZECHANGE flag is set. This is a part of the research work at RCSLab, University of Waterloo. Reviewed by: asomers Pull Request: https://github.com/freebsd/freebsd-src/pull/1110 (cherry picked from commit 8758bf0aaec1d4b2ebcb429e8cabc691c2c95461) --- sys/fs/fuse/fuse_internal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/fs/fuse/fuse_internal.c b/sys/fs/fuse/fuse_internal.c index c851cb2e34f4..adf84d30e801 100644 --- a/sys/fs/fuse/fuse_internal.c +++ b/sys/fs/fuse/fuse_internal.c @@ -270,10 +270,10 @@ fuse_internal_cache_attrs(struct vnode *vp, struct fuse_attr *attr, if (vnode_isreg(vp) && fvdat->cached_attrs.va_size != VNOVAL && + fvdat->flag & FN_SIZECHANGE && attr->size != fvdat->cached_attrs.va_size) { - if ( data->cache_mode == FUSE_CACHE_WB && - fvdat->flag & FN_SIZECHANGE) + if (data->cache_mode == FUSE_CACHE_WB) { const char *msg;