From owner-cvs-all@FreeBSD.ORG  Mon Jun  5 16:47:09 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2F4B316BCA5;
	Mon,  5 Jun 2006 16:47:01 +0000 (UTC)
	(envelope-from ghelmer@palisadesys.com)
Received: from magellan.palisadesys.com (magellan.palisadesys.com
	[192.188.162.211])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3DE5143D81;
	Mon,  5 Jun 2006 16:46:52 +0000 (GMT)
	(envelope-from ghelmer@palisadesys.com)
Received: from [172.16.1.108] (cetus.palisadesys.com [192.188.162.7])
	(authenticated bits=0)
	by magellan.palisadesys.com (8.13.4/8.13.4) with ESMTP id
	k55GkdYh040530
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Mon, 5 Jun 2006 11:46:39 -0500 (CDT)
	(envelope-from ghelmer@palisadesys.com)
Message-ID: <44845FEE.9030403@palisadesys.com>
Date: Mon, 05 Jun 2006 11:46:38 -0500
From: Guy Helmer <ghelmer@palisadesys.com>
User-Agent: Thunderbird 1.5.0.4 (Windows/20060516)
MIME-Version: 1.0
To: =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no>
References: <200605241403.k4OE3pvp007556@repoman.freebsd.org>	<86y7wf20qy.fsf@xps.des.no>
	<44808E83.4070704@palisadesys.com> <86fyilpdy3.fsf@dwp.des.no>
In-Reply-To: <86fyilpdy3.fsf@dwp.des.no>
X-Palisade-MailScanner-Information: Please contact the ISP for more information
X-Palisade-MailScanner: Found to be clean
X-Palisade-MailScanner-SpamCheck: not spam (whitelisted),
	SpamAssassin (score=-4.264, required 6, autolearn=not spam,
	ALL_TRUSTED -1.80, BAYES_00 -2.60, HTML_50_60 0.13,
	HTML_MESSAGE 0.00)
X-Palisade-MailScanner-From: ghelmer@palisadesys.com
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org,
	Guy Helmer <ghelmer@FreeBSD.org>, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/fs/procfs procfs.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Jun 2006 16:47:19 -0000

Dag-Erling Smørgrav wrote:
> Guy Helmer <ghelmer@palisadesys.com> writes:
>   
>> After applying this patch, /proc/<PID>/ctl is writable by the owner of a
>> P_SUGID process:
>>
>> --w-------  1 ph    ph     0 Jun  2 13:54 ctl
>>
>> (it used to be mode 000).  Is that OK?  It doesn't seem right to me...
>>     
>
> You're right, the &= ~077 shoud simply be = 0.
>
> DES
>   
OK, thanks.  I've committed the change.

Guy