From owner-freebsd-current@freebsd.org  Fri Dec 11 22:49:11 2015
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 31FC49D7957
 for <freebsd-current@mailman.ysv.freebsd.org>;
 Fri, 11 Dec 2015 22:49:11 +0000 (UTC)
 (envelope-from yaneurabeya@gmail.com)
Received: from mail-lb0-x22d.google.com (mail-lb0-x22d.google.com
 [IPv6:2a00:1450:4010:c04::22d])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id B7D2D1B20;
 Fri, 11 Dec 2015 22:49:10 +0000 (UTC)
 (envelope-from yaneurabeya@gmail.com)
Received: by lbblt2 with SMTP id lt2so78968707lbb.3;
 Fri, 11 Dec 2015 14:49:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=G1SWWlSLlZOvHqVz2hQZ2gu7UNsYeckCam1/NsI5JAs=;
 b=Xq0jiIWmrSxhrqqGtWyU4Vv09ee9QHImcEVqm9EQ05rtKCJ/yURuTpWCDZtbaQfXsn
 V4jqiwQImpDcLEaCYX4gzG7RXYVen7nOZnlFwPENzWiqYlCeTlsnBrh+Sn4+MXTThMk3
 MHO7uXb5cTHnKPprUM44N+wDSVqdWJELWT1v5mIxr1zb/r8HbkSy8+G7yH9ls9P1jFP/
 HwjAYAKRRcYUbYJ76rG+Cl0EGVcfLnbtVYOZDB3NhBEgq7TwAxAkvRI26rqMeIGi2BNO
 bIHgPKOiWkALU/yRFDTThQBVCI9qTvIhoI+fvgpfDLChB5JccJHSE9BO6juAFPDQk70L
 U+SQ==
MIME-Version: 1.0
X-Received: by 10.112.126.42 with SMTP id mv10mr8962046lbb.98.1449874148583;
 Fri, 11 Dec 2015 14:49:08 -0800 (PST)
Received: by 10.112.219.9 with HTTP; Fri, 11 Dec 2015 14:49:08 -0800 (PST)
In-Reply-To: <201512112119.tBBLJOYC048783@gw.catspoiler.org>
References: <20151211194204.GA26628@thinkpad.swarthmore.edu>
 <201512112119.tBBLJOYC048783@gw.catspoiler.org>
Date: Fri, 11 Dec 2015 14:49:08 -0800
Message-ID: <CAGHfRMCWA+RR0P5kuJx_TckF4C4UXnMK3dPcfFXsCxWLKBb4oQ@mail.gmail.com>
Subject: Re: XOR pt. 2
From: NGie Cooper <yaneurabeya@gmail.com>
To: Don Lewis <truckman@freebsd.org>
Cc: mmcco@mykolab.com, FreeBSD Current <freebsd-current@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Dec 2015 22:49:11 -0000

On Fri, Dec 11, 2015 at 1:19 PM, Don Lewis <truckman@freebsd.org> wrote:
> On 11 Dec, Michael McConville wrote:
>> Note that IFCAP_HWCSUM has two bits set. Because of this, it doesn't XOR
>> cleanly in the current if-else condition, but I'm not sure whether that
>> was intended. I just wanted to pass this by people in case it was a
>> logical bug.
>
> Yeah, the original code looks incorrect.   If HWCSUM is totally disabled
> and the user requests RXCSUM, then the current code will enable both
> RXCSUM and TXCSUM.

Please file a bug on bugzilla, CC erj, sbruno, and myself (ngie).
Thanks!
-NGie