From owner-freebsd-ports-bugs@freebsd.org Mon Feb 15 21:58:45 2021 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7137153C070 for ; Mon, 15 Feb 2021 21:58:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4DfdKK2ZSZz3jw8 for ; Mon, 15 Feb 2021 21:58:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 584FA53BF53; Mon, 15 Feb 2021 21:58:45 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 581CE53C06F for ; Mon, 15 Feb 2021 21:58:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DfdKK1xjHz3jlX for ; Mon, 15 Feb 2021 21:58:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3239B25381 for ; Mon, 15 Feb 2021 21:58:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11FLwjGV057214 for ; Mon, 15 Feb 2021 21:58:45 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11FLwjt6057213 for ports-bugs@FreeBSD.org; Mon, 15 Feb 2021 21:58:45 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 252085] new port: editors/codelite-devel: powerful open-source, cross platform code editor for the C/C++ programming languages (development version) Date: Mon, 15 Feb 2021 21:58:45 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: daniel.engberg.lists@pyret.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 21:58:45 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252085 --- Comment #4 from daniel.engberg.lists@pyret.net --- Hi Ivan, Can we transfer this to the main port instead? It's soon going to be broken= due to bumping pango. A few things that can be improved by looking at your Makefile L4 and L26: Please follow Porter's Handbook=20 https://docs.freebsd.org/en_US.ISO8859-1/books/porters-handbook/book.html#m= akefile-master_sites-github-ex5 L12 Seems to be GPLv2 ? Define LICENSE_FILE https://docs.freebsd.org/en_US.ISO8859-1/books/porters-handbook/book.html#l= icenses-license_file-ex1 L17 Remove? L27 is already defined by the framework https://svnweb.freebsd.org/ports/head/Mk/Uses/cmake.mk?revision=3D488341&vi= ew=3Dmarkup#l68 L34 is this really needed and if it is, please use a proper DEBUG menu opti= on https://github.com/eranif/codelite/blob/master/CMakeLists.txt#L429 L105, are you really sure about that? There is quite a bit of REINPLACE_CMD going on, this is in general discoura= ged perhaps usage can be reduced and replaced with patches? Some things are out of order, have a look at portlint and/or portclippy Does it pass poudriere? Great work! Daniel --=20 You are receiving this mail because: You are the assignee for the bug.=