From owner-cvs-src-old@FreeBSD.ORG Sat Aug 28 08:57:39 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 50E8B1065694 for ; Sat, 28 Aug 2010 08:57:39 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 24B3C8FC12 for ; Sat, 28 Aug 2010 08:57:39 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id o7S8vdOC056034 for ; Sat, 28 Aug 2010 08:57:39 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id o7S8vdo1056033 for cvs-src-old@freebsd.org; Sat, 28 Aug 2010 08:57:39 GMT (envelope-from pjd@repoman.freebsd.org) Message-Id: <201008280857.o7S8vdo1056033@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to pjd@repoman.freebsd.org using -f From: Pawel Jakub Dawidek Date: Sat, 28 Aug 2010 08:57:15 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern vfs_mount.c vfs_subr.c src/sys/sys mount.h X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Aug 2010 08:57:39 -0000 pjd 2010-08-28 08:57:15 UTC FreeBSD src repository Modified files: sys/kern vfs_mount.c vfs_subr.c sys/sys mount.h Log: SVN rev 211930 on 2010-08-28 08:57:15Z by pjd There is a bug in vfs_allocate_syncvnode() failure handling in mount code. Actually it is hard to properly handle such a failure, especially in MNT_UPDATE case. The only reason for the vfs_allocate_syncvnode() function to fail is getnewvnode() failure. Fortunately it is impossible for current implementation of getnewvnode() to fail, so we can assert this and make vfs_allocate_syncvnode() void. This in turn free us from handling its failures in the mount code. Reviewed by: kib MFC after: 1 month Revision Changes Path 1.317 +3 -5 src/sys/kern/vfs_mount.c 1.790 +5 -7 src/sys/kern/vfs_subr.c 1.252 +1 -1 src/sys/sys/mount.h