From owner-freebsd-hackers@FreeBSD.ORG Sun Nov 5 20:34:37 2006 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B99A216A40F for ; Sun, 5 Nov 2006 20:34:37 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id C9D3D43E61 for ; Sun, 5 Nov 2006 20:33:25 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (izdwqmav94dmxncr@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.6/8.13.3) with ESMTP id kA5KXBM4080764; Sun, 5 Nov 2006 12:33:11 -0800 (PST) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.6/8.13.3/Submit) id kA5KXBl7080763; Sun, 5 Nov 2006 12:33:11 -0800 (PST) (envelope-from jmg) Date: Sun, 5 Nov 2006 12:33:10 -0800 From: John-Mark Gurney To: usleepless@gmail.com Message-ID: <20061105203310.GR25511@funkthat.com> Mail-Followup-To: usleepless@gmail.com, freebsd-hackers@freebsd.org References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: freebsd-hackers@freebsd.org Subject: Re: taskqueue_drain X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Nov 2006 20:34:37 -0000 usleepless@gmail.com wrote this message on Wed, Oct 25, 2006 at 14:42 +0200: > i am working on improving the driver for hauppauge PVR cards > (multimedia/pvrxxx). i just implemented a "fast" interrupt using a > taskqueue ( like the new if_em driver ). > > i have a couple of questions: > 1. if_em is using taskqueue_enqueue rather than > taskqueue_enqueue_fast. this is contrary to what "man taskqueue" > claims. how come? Probably a bug... > 2. when my capture-device is closed, i need to drain the taskqueue. > however, taskqueue_drain needs a task as an argument. but i have > queued 2 different tasks on the taskqueue. what to do? i guess they > need to be processed "in order". Just drain each of them.. of course make sure that you unregister your interrupt (not just disable.. you could use a flag, as you may get interrupts due to shared interrupts) before draining the taskqueue... > 3. when and in which version will the "fast" versions of the > taskqueue-functions be released? will it be backported? if i create a > patch and send-pr it, is it likely to be accepted for 6.x? Someone else will have to answer this... /me wishes he had machines w/ more pci slots so he could keep all his cards attached for testing. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."