From owner-freebsd-bugs@FreeBSD.ORG Mon Sep 12 08:20:14 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 687B816A41F for ; Mon, 12 Sep 2005 08:20:14 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB73643D53 for ; Mon, 12 Sep 2005 08:20:12 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j8C8KCNl007327 for ; Mon, 12 Sep 2005 08:20:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j8C8KCT0007324; Mon, 12 Sep 2005 08:20:12 GMT (envelope-from gnats) Resent-Date: Mon, 12 Sep 2005 08:20:12 GMT Resent-Message-Id: <200509120820.j8C8KCT0007324@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ulrich Spoerlein Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F3D4A16A41F; Mon, 12 Sep 2005 08:10:37 +0000 (GMT) (envelope-from spoerlein@informatik.uni-wuerzburg.de) Received: from wrzx28.rz.uni-wuerzburg.de (wrzx28.rz.uni-wuerzburg.de [132.187.3.28]) by mx1.FreeBSD.org (Postfix) with ESMTP id 674BF43D45; Mon, 12 Sep 2005 08:10:37 +0000 (GMT) (envelope-from spoerlein@informatik.uni-wuerzburg.de) Received: from wrzx34.rz.uni-wuerzburg.de (wrzx34.rz.uni-wuerzburg.de [132.187.3.34]) by wrzx28.rz.uni-wuerzburg.de (Postfix) with ESMTP id B4CFB13B8BC; Mon, 12 Sep 2005 10:10:35 +0200 (CEST) Received: from virusscan (localhost [127.0.0.1]) by wrzx34.rz.uni-wuerzburg.de (Postfix) with ESMTP id 93F78B2EAD; Mon, 12 Sep 2005 10:10:35 +0200 (CEST) Received: from wrzx28.rz.uni-wuerzburg.de (wrzx28.rz.uni-wuerzburg.de [132.187.3.28]) by wrzx34.rz.uni-wuerzburg.de (Postfix) with ESMTP id 724B458FC0; Mon, 12 Sep 2005 10:10:35 +0200 (CEST) Received: from frodo.galgenberg.net (wwsx14.win-screen.uni-wuerzburg.de [132.187.253.14]) by wrzx28.rz.uni-wuerzburg.de (Postfix) with ESMTP id 3B95713B8BC; Mon, 12 Sep 2005 10:10:35 +0200 (CEST) Received: from coyote.q.local (gb-21-237.galgenberg.net [172.16.21.237]) by frodo.galgenberg.net (8.13.1/8.13.1) with ESMTP id j8C8AYQ2041125; Mon, 12 Sep 2005 10:10:34 +0200 (CEST) (envelope-from spoerlein@informatik.uni-wuerzburg.de) Received: from coyote.q.local (localhost [127.0.0.1]) by coyote.q.local (8.13.3/8.13.1) with ESMTP id j8C8AYGC053260; Mon, 12 Sep 2005 10:10:34 +0200 (CEST) (envelope-from q@coyote.q.local) Received: (from q@localhost) by coyote.q.local (8.13.3/8.13.1/Submit) id j8C8AYxL053259; Mon, 12 Sep 2005 10:10:34 +0200 (CEST) (envelope-from q) Message-Id: <200509120810.j8C8AYxL053259@coyote.q.local> Date: Mon, 12 Sep 2005 10:10:34 +0200 (CEST) From: Ulrich Spoerlein To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: grog@FreeBSD.org Subject: bin/86006: [PATCH] usr.sbin/asf: Fix segfault on bogus input X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Ulrich Spoerlein List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 08:20:14 -0000 >Number: 86006 >Category: bin >Synopsis: [PATCH] usr.sbin/asf: Fix segfault on bogus input >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Sep 12 08:20:12 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Ulrich Spoerlein >Release: FreeBSD 5.4-RELEASE-p2 i386 >Organization: >Environment: System: FreeBSD 5.4-RELEASE-p2 >Description: asf(8) uses uninitialized variables. I notices this while ... umm .. testing my keyboard with kbdmux. Please also have a look at bin/71653 which is yet another bug in asf(8). >How-To-Repeat: $ asf asf Segmentation fault (core dumped) >Fix: --- asf.patch begins here --- --- usr.sbin/asf/asf.c.orig Mon Sep 12 09:58:03 2005 +++ usr.sbin/asf/asf.c Mon Sep 12 10:02:44 2005 @@ -247,6 +247,9 @@ quad_t bssaddr; tokens = tokenize(buf, token, MAXTOKEN); + if (tokens < 4) + continue; + base = strtoll(token[2], NULL, 16); if (!dofind) { strcpy(basetoken, token[4]); --- asf.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: