From owner-cvs-all@FreeBSD.ORG Tue Jan 9 00:52:46 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9B33016A40F for ; Tue, 9 Jan 2007 00:52:46 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.225]) by mx1.freebsd.org (Postfix) with ESMTP id 42C1A13C457 for ; Tue, 9 Jan 2007 00:52:46 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by wx-out-0506.google.com with SMTP id s18so7576186wxc for ; Mon, 08 Jan 2007 16:52:45 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=rY9XShoiS3GvvshYOPZ6gJN41Q2XE2PmV9x0fjjfYQB/mgSIp1t0fkowhkPzF8oKhoxdLy5hBHO++me8vUWkiVo1od7XGAEeZsyT86q+k5EXJBPbwdau3vIF9ao8nS7pjar0jkUi6R9ZB+yt3mndSZ0iejxHzOYepm0Pq0U1Ljs= Received: by 10.70.40.1 with SMTP id n1mr49798369wxn.1168302233016; Mon, 08 Jan 2007 16:23:53 -0800 (PST) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.google.com with ESMTP id 43sm48090117wri.2007.01.08.16.23.50; Mon, 08 Jan 2007 16:23:52 -0800 (PST) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id l090OpsS029875 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 9 Jan 2007 09:24:51 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id l090Ook8029874; Tue, 9 Jan 2007 09:24:50 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Tue, 9 Jan 2007 09:24:50 +0900 From: Pyun YongHyeon To: John Baldwin Message-ID: <20070109002450.GA24958@cdnetworks.co.kr> References: <200701080019.l080Js9g077860@repoman.freebsd.org> <200701081135.59717.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200701081135.59717.jhb@freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Pyun YongHyeon Subject: Re: cvs commit: src/sys/dev/msk if_msk.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2007 00:52:46 -0000 On Mon, Jan 08, 2007 at 11:35:59AM -0500, John Baldwin wrote: > On Sunday 07 January 2007 19:19, Pyun YongHyeon wrote: > > yongari 2007-01-08 00:19:53 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/msk if_msk.c > > Log: > > Initialize legacy SYS_RES_IRQ resources before attempting to use MSI. > > This fixes legacy SYS_RES_IRQ resource allocation failure when MSI is > > disabled. > > > > Reported by: rrs > > Tested by: rrs > > Gah, my bad. I would prefer to set it down before the 'if (msic == 2...)' so > all the logic for it is in one place, but anyways, you should remove the At first I thought that too. But mskc_attach() checks chip id and then exits if the chip is not supported one. If that happens mskc_detach() will call bus_release_resources() with invalid SYS_RES_IRQ resources. > now-duplicate setting here: > > } else { > pci_release_msi(dev); > sc->msk_irq_spec = msk_irq_spec_legacy; Indeed, I'll do. Thanks a lot! > } > > -- > John Baldwin -- Regards, Pyun YongHyeon