From owner-svn-src-all@FreeBSD.ORG Tue Oct 11 23:10:56 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 225F41065672; Tue, 11 Oct 2011 23:10:56 +0000 (UTC) (envelope-from des@des.no) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id D42878FC14; Tue, 11 Oct 2011 23:10:55 +0000 (UTC) Received: from ds4.des.no (des.no [84.49.246.2]) by smtp.des.no (Postfix) with ESMTP id CD3621FFC34; Tue, 11 Oct 2011 23:10:54 +0000 (UTC) Received: by ds4.des.no (Postfix, from userid 1001) id 9F929B95F; Wed, 12 Oct 2011 01:10:54 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Garrett Cooper References: <201110081247.p98Cl06s063337@svn.freebsd.org> Date: Wed, 12 Oct 2011 01:10:54 +0200 In-Reply-To: (Garrett Cooper's message of "Tue, 11 Oct 2011 08:45:24 -0700") Message-ID: <86sjmzruo1.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r226157 - head/usr.bin/kdump X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2011 23:10:56 -0000 Garrett Cooper writes: > Seeing that you've committed quite a bit to kdump recently, could > you please take a look at > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D161478 ? Hmm, did you run across this while testing your patch? % make cc -O2 -pipe -I/usr/src/usr.bin/kdump/../ktrace -I/usr/src/usr.bin/kdump -= I/usr/src/usr.bin/kdump/../.. -I. -g -std=3Dgnu99 -fstack-protector -Wsyste= m-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-p= rototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -W= write-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subs= cripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -= Wno-pointer-sign -c ioctl.c cc1: warnings being treated as errors In file included from ioctl.c:80: /usr/include/netinet/ip_fil.h:1284: warning: redundant redeclaration of 'bc= opywrap' /usr/include/netinet/ip_compat.h:1543: warning: previous declaration of 'bc= opywrap' was here *** Error code 1 Stop in /usr/src/usr.bin/kdump. I don't understand why it complains, since both declarations are identical, modulo whitespace: % grep -r bcopywrap /usr/include/netinet /usr/include/netinet/ip_fil.h:extern int bcopywrap __P((void *, vo= id *, size_t)); /usr/include/netinet/ip_compat.h:# define COPYIN(a,b,c) bcopywrap((a), = (b), (c)) /usr/include/netinet/ip_compat.h:# define COPYOUT(a,b,c) bcopywrap((a), = (b), (c)) /usr/include/netinet/ip_compat.h:extern int bcopywrap __P((= void *, void *, size_t)); % make DEBUG_FLAGS=3D"-g -save-temps" [...] % grep bcopywrap /usr/obj/usr/src/usr.bin/kdump/ioctl.i extern int bcopywrap (void *, void *, size_t); extern int bcopywrap (void *, void *, size_t); BTW, the extern keyword is completely pointless, since it is implicit for functions. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no